From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Mark Brown <broonie@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-spi@vger.kernel.org (open list:SPI SUBSYSTEM)
Subject: [PATCH 2/2] spi: atmel: Add missing annotation for atmel_spi_next_xfer_dma_submit()
Date: Wed, 29 Apr 2020 23:57:23 +0100 [thread overview]
Message-ID: <20200429225723.31258-3-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200429225723.31258-1-jbi.octave@gmail.com>
Sparse reports a warning at atmel_spi_next_xfer_dma_submit()
warning: context imbalance in atmel_spi_next_xfer_dma_submit()
- unexpected unlock
The root cause is the missing annotation
at atmel_spi_next_xfer_dma_submit()
Add the missing __must_hold(&as->lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/spi/spi-atmel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 013458cabe3c..57ee8c3b7972 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -706,6 +706,7 @@ static void atmel_spi_next_xfer_pio(struct spi_master *master,
static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
struct spi_transfer *xfer,
u32 *plen)
+ __must_hold(&as->lock)
{
struct atmel_spi *as = spi_master_get_devdata(master);
struct dma_chan *rxchan = master->dma_rx;
--
2.26.2
next prev parent reply other threads:[~2020-04-29 22:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/2>
2020-01-30 0:28 ` [PATCH 0/2] Lock warning clean up Jules Irenge
2020-01-30 0:29 ` [PATCH 1/2] fs_pin: Add missing annotation to pin_kill() declaration Jules Irenge
2020-01-30 0:30 ` [PATCH 2/2] rcu/nocb: Add missing annotation for rcu_nocb_bypass_unlock() Jules Irenge
2020-01-31 0:59 ` Boqun Feng
2020-01-31 4:42 ` Paul E. McKenney
2020-04-29 22:57 ` [PATCH 0/2] Lock warning cleanup Jules Irenge
2020-04-29 22:57 ` [PATCH 1/2] cxgb4: Add missing annotation for service_ofldq() Jules Irenge
2020-04-29 22:57 ` Jules Irenge [this message]
2020-04-30 14:23 ` [PATCH 0/2] Lock warning cleanup Mark Brown
2020-04-30 14:41 ` Mark Brown
[not found] ` <20200803122430.82364-1-jbi.octave@gmail.com>
2020-08-03 12:24 ` [PATCH 1/2] audit: change unnecessary globals into statics Jules Irenge
2020-08-03 12:24 ` [PATCH 2/2] audit: uninitialize variable audit_sig_sid Jules Irenge
2020-08-03 12:34 ` [RESEND PATCH 0/2] cleanups Jules Irenge
2020-08-03 12:34 ` [RESEND PATCH 1/2] audit: change unnecessary globals into statics Jules Irenge
2020-08-06 18:33 ` Paul Moore
2020-08-18 0:38 ` Paul Moore
2020-08-03 12:34 ` [RESEND PATCH 2/2] audit: uninitialize variable audit_sig_sid Jules Irenge
2020-08-06 18:35 ` Paul Moore
2020-08-18 0:38 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429225723.31258-3-jbi.octave@gmail.com \
--to=jbi.octave@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox