* [PATCH] drivers/iommu: properly export iommu_group_get_for_dev
@ 2020-04-30 12:01 Greg Kroah-Hartman
2020-04-30 12:17 ` Will Deacon
2020-05-01 11:33 ` Joerg Roedel
0 siblings, 2 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-04-30 12:01 UTC (permalink / raw)
To: joro
Cc: iommu, linux-kernel, Greg Kroah-Hartman, Will Deacon,
Joerg Roedel, John Garry
In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to
permit modular drivers") a bunch of iommu symbols were exported, all
with _GPL markings except iommu_group_get_for_dev(). That export should
also be _GPL like the others.
Cc: Will Deacon <will@kernel.org>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: John Garry <john.garry@huawei.com>
Fixes: a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/iommu/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 2b471419e26c..1ecbc8788fe7 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1428,7 +1428,7 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)
return group;
}
-EXPORT_SYMBOL(iommu_group_get_for_dev);
+EXPORT_SYMBOL_GPL(iommu_group_get_for_dev);
struct iommu_domain *iommu_group_default_domain(struct iommu_group *group)
{
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev
2020-04-30 12:01 [PATCH] drivers/iommu: properly export iommu_group_get_for_dev Greg Kroah-Hartman
@ 2020-04-30 12:17 ` Will Deacon
2020-04-30 12:23 ` Joerg Roedel
2020-05-01 11:33 ` Joerg Roedel
1 sibling, 1 reply; 5+ messages in thread
From: Will Deacon @ 2020-04-30 12:17 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: joro, iommu, linux-kernel, Joerg Roedel, John Garry
On Thu, Apr 30, 2020 at 02:01:20PM +0200, Greg Kroah-Hartman wrote:
> In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to
> permit modular drivers") a bunch of iommu symbols were exported, all
> with _GPL markings except iommu_group_get_for_dev(). That export should
> also be _GPL like the others.
>
> Cc: Will Deacon <will@kernel.org>
> Cc: Joerg Roedel <jroedel@suse.de>
> Cc: John Garry <john.garry@huawei.com>
> Fixes: a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/iommu/iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 2b471419e26c..1ecbc8788fe7 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -1428,7 +1428,7 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)
>
> return group;
> }
> -EXPORT_SYMBOL(iommu_group_get_for_dev);
> +EXPORT_SYMBOL_GPL(iommu_group_get_for_dev);
>
> struct iommu_domain *iommu_group_default_domain(struct iommu_group *group)
> {
Thanks, not sure how I managed to screw this up in the original patch!
Acked-by: Will Deacon <will@kernel.org>
Joerg -- can you pick this one up please?
Cheers,
Will
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev
2020-04-30 12:17 ` Will Deacon
@ 2020-04-30 12:23 ` Joerg Roedel
2020-05-01 7:07 ` Will Deacon
0 siblings, 1 reply; 5+ messages in thread
From: Joerg Roedel @ 2020-04-30 12:23 UTC (permalink / raw)
To: Will Deacon
Cc: Greg Kroah-Hartman, iommu, linux-kernel, Joerg Roedel, John Garry
On Thu, Apr 30, 2020 at 01:17:53PM +0100, Will Deacon wrote:
> Thanks, not sure how I managed to screw this up in the original patch!
>
> Acked-by: Will Deacon <will@kernel.org>
>
> Joerg -- can you pick this one up please?
Yes, will send it as a fix for 5.7, but note that this function will be
unexported in 5.8.
Regards,
Joerg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev
2020-04-30 12:23 ` Joerg Roedel
@ 2020-05-01 7:07 ` Will Deacon
0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2020-05-01 7:07 UTC (permalink / raw)
To: Joerg Roedel
Cc: Greg Kroah-Hartman, iommu, linux-kernel, Joerg Roedel, John Garry
On Thu, Apr 30, 2020 at 02:23:32PM +0200, Joerg Roedel wrote:
> On Thu, Apr 30, 2020 at 01:17:53PM +0100, Will Deacon wrote:
> > Thanks, not sure how I managed to screw this up in the original patch!
> >
> > Acked-by: Will Deacon <will@kernel.org>
> >
> > Joerg -- can you pick this one up please?
>
> Yes, will send it as a fix for 5.7, but note that this function will be
> unexported in 5.8.
Thanks, Joerg.
Will
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev
2020-04-30 12:01 [PATCH] drivers/iommu: properly export iommu_group_get_for_dev Greg Kroah-Hartman
2020-04-30 12:17 ` Will Deacon
@ 2020-05-01 11:33 ` Joerg Roedel
1 sibling, 0 replies; 5+ messages in thread
From: Joerg Roedel @ 2020-05-01 11:33 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: iommu, linux-kernel, Will Deacon, Joerg Roedel, John Garry
On Thu, Apr 30, 2020 at 02:01:20PM +0200, Greg Kroah-Hartman wrote:
> In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to
> permit modular drivers") a bunch of iommu symbols were exported, all
> with _GPL markings except iommu_group_get_for_dev(). That export should
> also be _GPL like the others.
>
> Cc: Will Deacon <will@kernel.org>
> Cc: Joerg Roedel <jroedel@suse.de>
> Cc: John Garry <john.garry@huawei.com>
> Fixes: a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/iommu/iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied for v5.7, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-01 11:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-30 12:01 [PATCH] drivers/iommu: properly export iommu_group_get_for_dev Greg Kroah-Hartman
2020-04-30 12:17 ` Will Deacon
2020-04-30 12:23 ` Joerg Roedel
2020-05-01 7:07 ` Will Deacon
2020-05-01 11:33 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox