* [PATCH] MIPS: tools: Show result for loongson3-llsc-check
@ 2020-04-30 12:36 Tiezhu Yang
2020-04-30 15:05 ` Thomas Bogendoerfer
2020-05-01 9:48 ` Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Tiezhu Yang @ 2020-04-30 12:36 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: linux-mips, linux-kernel, Xuefeng Li
It is better to show the result before loongson3-llsc-check exit,
otherwise we can see nothing if the return status is EXIT_SUCCESS,
it seems confusing.
E.g. without this patch:
[loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux
[loongson@localhost tools]$
With this patch:
[loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux
loongson3-llsc-check returns success
[loongson@localhost tools]$
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
arch/mips/tools/loongson3-llsc-check.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/tools/loongson3-llsc-check.c b/arch/mips/tools/loongson3-llsc-check.c
index 0ebddd0..facd016 100644
--- a/arch/mips/tools/loongson3-llsc-check.c
+++ b/arch/mips/tools/loongson3-llsc-check.c
@@ -303,5 +303,7 @@ int main(int argc, char *argv[])
out_close:
close(vmlinux_fd);
out_ret:
+ fprintf(stdout, "loongson3-llsc-check %s\n",
+ status ? "returns failure" : "returns success");
return status;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: tools: Show result for loongson3-llsc-check
2020-04-30 12:36 [PATCH] MIPS: tools: Show result for loongson3-llsc-check Tiezhu Yang
@ 2020-04-30 15:05 ` Thomas Bogendoerfer
2020-05-01 9:48 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2020-04-30 15:05 UTC (permalink / raw)
To: Tiezhu Yang; +Cc: linux-mips, linux-kernel, Xuefeng Li
On Thu, Apr 30, 2020 at 08:36:24PM +0800, Tiezhu Yang wrote:
> It is better to show the result before loongson3-llsc-check exit,
> otherwise we can see nothing if the return status is EXIT_SUCCESS,
> it seems confusing.
>
> E.g. without this patch:
>
> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux
> [loongson@localhost tools]$
>
> With this patch:
>
> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux
> loongson3-llsc-check returns success
> [loongson@localhost tools]$
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> arch/mips/tools/loongson3-llsc-check.c | 2 ++
> 1 file changed, 2 insertions(+)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: tools: Show result for loongson3-llsc-check
2020-04-30 12:36 [PATCH] MIPS: tools: Show result for loongson3-llsc-check Tiezhu Yang
2020-04-30 15:05 ` Thomas Bogendoerfer
@ 2020-05-01 9:48 ` Sergei Shtylyov
2020-05-02 3:33 ` Tiezhu Yang
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2020-05-01 9:48 UTC (permalink / raw)
To: Tiezhu Yang, Thomas Bogendoerfer; +Cc: linux-mips, linux-kernel, Xuefeng Li
Hello!
On 30.04.2020 15:36, Tiezhu Yang wrote:
> It is better to show the result before loongson3-llsc-check exit,
> otherwise we can see nothing if the return status is EXIT_SUCCESS,
> it seems confusing.
>
> E.g. without this patch:
>
> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux
> [loongson@localhost tools]$
>
> With this patch:
>
> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux
> loongson3-llsc-check returns success
> [loongson@localhost tools]$
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> arch/mips/tools/loongson3-llsc-check.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/tools/loongson3-llsc-check.c b/arch/mips/tools/loongson3-llsc-check.c
> index 0ebddd0..facd016 100644
> --- a/arch/mips/tools/loongson3-llsc-check.c
> +++ b/arch/mips/tools/loongson3-llsc-check.c
> @@ -303,5 +303,7 @@ int main(int argc, char *argv[])
> out_close:
> close(vmlinux_fd);
> out_ret:
> + fprintf(stdout, "loongson3-llsc-check %s\n",
> + status ? "returns failure" : "returns success");
Why not "loongson3-llsc-check returns %s\n"?
> return status;
> }
>
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: tools: Show result for loongson3-llsc-check
2020-05-01 9:48 ` Sergei Shtylyov
@ 2020-05-02 3:33 ` Tiezhu Yang
0 siblings, 0 replies; 4+ messages in thread
From: Tiezhu Yang @ 2020-05-02 3:33 UTC (permalink / raw)
To: Sergei Shtylyov, Thomas Bogendoerfer; +Cc: linux-mips, linux-kernel, Xuefeng Li
On 05/01/2020 05:48 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 30.04.2020 15:36, Tiezhu Yang wrote:
>
>> It is better to show the result before loongson3-llsc-check exit,
>> otherwise we can see nothing if the return status is EXIT_SUCCESS,
>> it seems confusing.
>>
>> E.g. without this patch:
>>
>> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux
>> [loongson@localhost tools]$
>>
>> With this patch:
>>
>> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux
>> loongson3-llsc-check returns success
>> [loongson@localhost tools]$
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>> arch/mips/tools/loongson3-llsc-check.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/mips/tools/loongson3-llsc-check.c
>> b/arch/mips/tools/loongson3-llsc-check.c
>> index 0ebddd0..facd016 100644
>> --- a/arch/mips/tools/loongson3-llsc-check.c
>> +++ b/arch/mips/tools/loongson3-llsc-check.c
>> @@ -303,5 +303,7 @@ int main(int argc, char *argv[])
>> out_close:
>> close(vmlinux_fd);
>> out_ret:
>> + fprintf(stdout, "loongson3-llsc-check %s\n",
>> + status ? "returns failure" : "returns success");
>
> Why not "loongson3-llsc-check returns %s\n"?
Hi Sergei,
Sorry for the late reply, thanks for your review, I will send v2.
Thanks,
Tiezhu Yang
>
>> return status;
>> }
>>
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-02 3:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-30 12:36 [PATCH] MIPS: tools: Show result for loongson3-llsc-check Tiezhu Yang
2020-04-30 15:05 ` Thomas Bogendoerfer
2020-05-01 9:48 ` Sergei Shtylyov
2020-05-02 3:33 ` Tiezhu Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox