From: Vincent Cheng <vincent.cheng.xh@renesas.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] ptp: ptp_clockmatrix: Add adjphase() to support PHC write phase mode.
Date: Fri, 1 May 2020 09:51:29 -0400 [thread overview]
Message-ID: <20200501135127.GB19989@renesas.com> (raw)
In-Reply-To: <20200501035601.GC31749@localhost>
On Thu, Apr 30, 2020 at 11:56:01PM EDT, Richard Cochran wrote:
>On Wed, Apr 29, 2020 at 08:28:25PM -0400, vincent.cheng.xh@renesas.com wrote:
>> @@ -871,6 +880,69 @@ static int idtcm_set_pll_mode(struct idtcm_channel *channel,
>>
>> + int err;
>> + u8 i;
>> + u8 buf[4] = {0};
>> + s32 phaseIn50Picoseconds;
>> + s64 phaseOffsetInPs;
>
>Kernel coding style uses lower_case_underscores rather than lowerCamelCase.
Sorry, missed that. Will fix.
>> + kthread_queue_delayed_work(channel->kworker,
>> + &channel->write_phase_ready_work,
>> + msecs_to_jiffies(WR_PHASE_SETUP_MS));
>
>Each PHC driver automatically has a kworker provided by the class
>layer. In order to use it, set ptp_clock_info.do_aux_work to your
>callback function and then call ptp_schedule_worker() when needed.
>
>See drivers/net/ethernet/ti/cpts.c for example.
That is nice of the API, thank-you for the example. Will fix and re-submit.
Thanks,
Vincent
prev parent reply other threads:[~2020-05-01 13:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 0:28 [PATCH net-next 0/3] ptp: Add adjust phase to support phase offset vincent.cheng.xh
2020-04-30 0:28 ` [PATCH net-next 1/3] ptp: Add adjphase function to support phase offset control vincent.cheng.xh
2020-05-01 3:37 ` Richard Cochran
2020-05-01 13:48 ` Vincent Cheng
2020-04-30 0:28 ` [PATCH net-next 2/3] ptp: Add adjust_phase to ptp_clock_caps capability vincent.cheng.xh
2020-05-01 3:38 ` Richard Cochran
2020-04-30 0:28 ` [PATCH net-next 3/3] ptp: ptp_clockmatrix: Add adjphase() to support PHC write phase mode vincent.cheng.xh
2020-05-01 3:56 ` Richard Cochran
2020-05-01 13:51 ` Vincent Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501135127.GB19989@renesas.com \
--to=vincent.cheng.xh@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox