From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D87D0C35280 for ; Fri, 1 May 2020 20:52:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDD3621835 for ; Fri, 1 May 2020 20:52:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727880AbgEAUwQ (ORCPT ); Fri, 1 May 2020 16:52:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:53472 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726384AbgEAUwP (ORCPT ); Fri, 1 May 2020 16:52:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 615D0ACB1; Fri, 1 May 2020 20:52:13 +0000 (UTC) Received: by lion.mk-sys.cz (Postfix, from userid 1000) id 307A1602E9; Fri, 1 May 2020 22:52:12 +0200 (CEST) Date: Fri, 1 May 2020 22:52:12 +0200 From: Michal Kubecek To: netdev@vger.kernel.org Cc: Oleksij Rempel , Andrew Lunn , "David S. Miller" , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Jonathan Corbet , David Jander , kernel@pengutronix.de, linux-kernel@vger.kernel.org, Russell King , mkl@pengutronix.de, Marek Vasut , Christian Herber Subject: Re: [PATCH net-next v4 1/2] ethtool: provide UAPI for PHY master/slave configuration. Message-ID: <20200501205212.GE8976@lion.mk-sys.cz> References: <20200501074633.24421-1-o.rempel@pengutronix.de> <20200501074633.24421-2-o.rempel@pengutronix.de> <20200501155210.GD8976@lion.mk-sys.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200501155210.GD8976@lion.mk-sys.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2020 at 05:52:10PM +0200, Michal Kubecek wrote: > On Fri, May 01, 2020 at 09:46:32AM +0200, Oleksij Rempel wrote: > [...] > > static int ethnl_update_linkmodes(struct genl_info *info, struct nlattr **tb, > > struct ethtool_link_ksettings *ksettings, > > bool *mod) > > { > > struct ethtool_link_settings *lsettings = &ksettings->base; > > bool req_speed, req_duplex; > > + const struct nlattr *attr; > > int ret; > > > > + attr = tb[ETHTOOL_A_LINKMODES_MASTER_SLAVE_CFG]; > > + if (attr) { > > Introducing the variable makes little sense if this is the only place > where it is used. But if you decide to use it also in the two other > places working with the attribute, it should probably have more > descriptive name. > > Michal > > > + u8 cfg = nla_get_u8(tb[ETHTOOL_A_LINKMODES_MASTER_SLAVE_CFG]); > > + if (!ethnl_validate_master_slave_cfg(cfg)) > > + return -EOPNOTSUPP; > > + } Also, please set extack error message and bad attribute when the check fails. Michal > > + > > *mod = false; > > req_speed = tb[ETHTOOL_A_LINKMODES_SPEED]; > > req_duplex = tb[ETHTOOL_A_LINKMODES_DUPLEX]; > > @@ -311,6 +357,8 @@ static int ethnl_update_linkmodes(struct genl_info *info, struct nlattr **tb, > > mod); > > ethnl_update_u8(&lsettings->duplex, tb[ETHTOOL_A_LINKMODES_DUPLEX], > > mod); > > + ethnl_update_u8(&lsettings->master_slave_cfg, > > + tb[ETHTOOL_A_LINKMODES_MASTER_SLAVE_CFG], mod); > > > > if (!tb[ETHTOOL_A_LINKMODES_OURS] && lsettings->autoneg && > > (req_speed || req_duplex) && > > -- > > 2.26.2 > >