Re: [PATCH v24 02/16] leds: multicolor: Introduce a multicolor class definition

kbuild test robot
2020-05-04T21:18:50Z

Hi Dan,

I love your patch! Yet something to improve:

[auto build test ERROR on pavel-linux-leds/for-next]
[also build test ERROR on robh/for-next linus/master j.anaszewski-leds/for-next v5.7-rc4 next-20200504]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Dan-Murphy/Multicolor-Framework-v24/20200505-031241
base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
config: parisc-allnoconfig
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=parisc allnoconfig
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=parisc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/leds/Kconfig:33:error: recursive dependency detected!
>> drivers/leds/Kconfig:33: symbol LEDS_CLASS_MULTI_COLOR depends on LEDS_CLASS_MULTI_COLOR
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"

vim +33 drivers/leds/Kconfig

16
17 config LEDS_CLASS
18 tristate "LED Class Support"
19 help
20 This option enables the LED sysfs class in /sys/class/leds. You'll
21 need this to do anything useful with LEDs. If unsure, say N.
22
23 config LEDS_CLASS_FLASH
24 tristate "LED Flash Class Support"
25 depends on LEDS_CLASS
26 help
27 This option enables the flash LED sysfs class in /sys/class/leds.
28 It wraps LED Class and adds flash LEDs specific sysfs attributes
29 and kernel internal API to it. You'll need this to provide support
30 for the flash related features of a LED device. It can be built
31 as a module.
32
> 33 config LEDS_CLASS_MULTI_COLOR
34 tristate "LED MultiColor LED Class Support"
35 depends on LEDS_CLASS
36 depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR
37 help
38 This option enables the multicolor LED sysfs class in /sys/class/leds.
39 It wraps LED class and adds multicolor LED specific sysfs attributes
40 and kernel internal API to it. You'll need this to provide support
41 for multicolor LEDs that are grouped together. This class is not
42 intended for single color LEDs. It can be built as a module.
43

---
0-DAY CI Kernel Test Service, Intel Corporation