From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69F2C47247 for ; Sun, 3 May 2020 11:42:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C13320757 for ; Sun, 3 May 2020 11:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588506136; bh=cJV6+Ip85K8eZlfSHfw7Jg5xJtOOcTfm2AIj0IoaByo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=KBfKxGTBM2YZpHgL1hTN9pDLBBSOwM6b1J2xRc8aBK0CcHTDh6hsPJrBKuFkJdzLU Afj5VGZ+fbD0zSv2qwaJ2kebBC+/L8ueUe8v8QzKE4pYhex+5Anc2etyKim425Hv5v fUU0n/tmG3+nXOZbEn1nYrt7xToh5tMuoeyf7nKI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbgECLmQ (ORCPT ); Sun, 3 May 2020 07:42:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:39222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727023AbgECLmP (ORCPT ); Sun, 3 May 2020 07:42:15 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C8FB205ED; Sun, 3 May 2020 11:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588506135; bh=cJV6+Ip85K8eZlfSHfw7Jg5xJtOOcTfm2AIj0IoaByo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NmRh3zxCTBSlXzH2Wve48cUWyleTnCms9h/zOVYJRbGeIOaH+UziEkUBrn9qZzBJW 786adg9qmXPRSJpZWw2hsjJWSYSh8RwBdZS9IaQ5sdlG/N4nx9r3mrzKu5jIz5dwLU pHT7YO4/iclXvBuKXYMtC19wije0c4azj9FBaUlM= Date: Sun, 3 May 2020 12:42:11 +0100 From: Jonathan Cameron To: Sergiu Cuciurean Cc: , , , Subject: Re: [PATCH] iio: adc: ad7768-1: Fix channel endian spec Message-ID: <20200503124211.41933e29@archlinux> In-Reply-To: <20200429104535.82988-1-sergiu.cuciurean@analog.com> References: <20200429104535.82988-1-sergiu.cuciurean@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Apr 2020 13:45:35 +0300 Sergiu Cuciurean wrote: > This change removes the endian description from the iio channel spec. > In this way, the default (IIO_CPU) endian will be used, matching the > be32_to_cpu() conversion from ad7768_spi_reg_read(). > > Fixes: 8a15c73a9bcfe ("iio: adc: Add AD7768-1 ADC basic support") > > Signed-off-by: Sergiu Cuciurean Hi Sergiu, The endian marking only applies to the push_to_buffers data. That is read from the hardware using spi_read, not the ad7768_spi_reg_read function. So logic above doesn't hold. Thanks, Jonathan > --- > drivers/iio/adc/ad7768-1.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c > index a0027797a7fe..99da13c3511a 100644 > --- a/drivers/iio/adc/ad7768-1.c > +++ b/drivers/iio/adc/ad7768-1.c > @@ -144,7 +144,6 @@ static const struct iio_chan_spec ad7768_channels[] = { > .realbits = 24, > .storagebits = 32, > .shift = 8, > - .endianness = IIO_BE, > }, > }, > };