From: Joyce Ooi <joyce.ooi@intel.com>
To: Thor Thayer <thor.thayer@linux.intel.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Dalon Westergreen <dalon.westergreen@intel.com>,
Joyce Ooi <joyce.ooi@intel.com>,
Tan Ley Foon <ley.foon.tan@intel.com>,
See Chin Liang <chin.liang.see@intel.com>,
Dinh Nguyen <dinh.nguyen@intel.com>,
Dalon Westergreen <dalon.westergreen@linux.intel.com>
Subject: [PATCHv2 06/10] net: eth: altera: Add missing identifier names to function declarations
Date: Mon, 4 May 2020 16:25:54 +0800 [thread overview]
Message-ID: <20200504082558.112627-7-joyce.ooi@intel.com> (raw)
In-Reply-To: <20200504082558.112627-1-joyce.ooi@intel.com>
From: Dalon Westergreen <dalon.westergreen@linux.intel.com>
The sgdma and msgdma header files included function declarations
without identifier names for pointers. Add appropriate identifier
names.
Signed-off-by: Dalon Westergreen <dalon.westergreen@linux.intel.com>
Signed-off-by: Joyce Ooi <joyce.ooi@intel.com>
---
v2: this patch is added in patch version 2
---
drivers/net/ethernet/altera/altera_msgdma.h | 30 ++++++++++++++-------------
drivers/net/ethernet/altera/altera_sgdma.h | 32 +++++++++++++++--------------
2 files changed, 33 insertions(+), 29 deletions(-)
diff --git a/drivers/net/ethernet/altera/altera_msgdma.h b/drivers/net/ethernet/altera/altera_msgdma.h
index 9813fbfff4d3..23f5b2a13898 100644
--- a/drivers/net/ethernet/altera/altera_msgdma.h
+++ b/drivers/net/ethernet/altera/altera_msgdma.h
@@ -6,19 +6,21 @@
#ifndef __ALTERA_MSGDMA_H__
#define __ALTERA_MSGDMA_H__
-void msgdma_reset(struct altera_tse_private *);
-void msgdma_enable_txirq(struct altera_tse_private *);
-void msgdma_enable_rxirq(struct altera_tse_private *);
-void msgdma_disable_rxirq(struct altera_tse_private *);
-void msgdma_disable_txirq(struct altera_tse_private *);
-void msgdma_clear_rxirq(struct altera_tse_private *);
-void msgdma_clear_txirq(struct altera_tse_private *);
-u32 msgdma_tx_completions(struct altera_tse_private *);
-void msgdma_add_rx_desc(struct altera_tse_private *, struct tse_buffer *);
-int msgdma_tx_buffer(struct altera_tse_private *, struct tse_buffer *);
-u32 msgdma_rx_status(struct altera_tse_private *);
-int msgdma_initialize(struct altera_tse_private *);
-void msgdma_uninitialize(struct altera_tse_private *);
-void msgdma_start_rxdma(struct altera_tse_private *);
+void msgdma_reset(struct altera_tse_private *priv);
+void msgdma_enable_txirq(struct altera_tse_private *priv);
+void msgdma_enable_rxirq(struct altera_tse_private *priv);
+void msgdma_disable_rxirq(struct altera_tse_private *priv);
+void msgdma_disable_txirq(struct altera_tse_private *priv);
+void msgdma_clear_rxirq(struct altera_tse_private *priv);
+void msgdma_clear_txirq(struct altera_tse_private *priv);
+u32 msgdma_tx_completions(struct altera_tse_private *priv);
+void msgdma_add_rx_desc(struct altera_tse_private *priv,
+ struct tse_buffer *buffer);
+int msgdma_tx_buffer(struct altera_tse_private *priv,
+ struct tse_buffer *buffer);
+u32 msgdma_rx_status(struct altera_tse_private *priv);
+int msgdma_initialize(struct altera_tse_private *priv);
+void msgdma_uninitialize(struct altera_tse_private *priv);
+void msgdma_start_rxdma(struct altera_tse_private *priv);
#endif /* __ALTERA_MSGDMA_H__ */
diff --git a/drivers/net/ethernet/altera/altera_sgdma.h b/drivers/net/ethernet/altera/altera_sgdma.h
index 08afe1c9994f..3fb201417820 100644
--- a/drivers/net/ethernet/altera/altera_sgdma.h
+++ b/drivers/net/ethernet/altera/altera_sgdma.h
@@ -6,20 +6,22 @@
#ifndef __ALTERA_SGDMA_H__
#define __ALTERA_SGDMA_H__
-void sgdma_reset(struct altera_tse_private *);
-void sgdma_enable_txirq(struct altera_tse_private *);
-void sgdma_enable_rxirq(struct altera_tse_private *);
-void sgdma_disable_rxirq(struct altera_tse_private *);
-void sgdma_disable_txirq(struct altera_tse_private *);
-void sgdma_clear_rxirq(struct altera_tse_private *);
-void sgdma_clear_txirq(struct altera_tse_private *);
-int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *);
-u32 sgdma_tx_completions(struct altera_tse_private *);
-void sgdma_add_rx_desc(struct altera_tse_private *priv, struct tse_buffer *);
-void sgdma_status(struct altera_tse_private *);
-u32 sgdma_rx_status(struct altera_tse_private *);
-int sgdma_initialize(struct altera_tse_private *);
-void sgdma_uninitialize(struct altera_tse_private *);
-void sgdma_start_rxdma(struct altera_tse_private *);
+void sgdma_reset(struct altera_tse_private *priv);
+void sgdma_enable_txirq(struct altera_tse_private *priv);
+void sgdma_enable_rxirq(struct altera_tse_private *priv);
+void sgdma_disable_rxirq(struct altera_tse_private *priv);
+void sgdma_disable_txirq(struct altera_tse_private *priv);
+void sgdma_clear_rxirq(struct altera_tse_private *priv);
+void sgdma_clear_txirq(struct altera_tse_private *priv);
+int sgdma_tx_buffer(struct altera_tse_private *priv,
+ struct tse_buffer *buffer);
+u32 sgdma_tx_completions(struct altera_tse_private *priv);
+void sgdma_add_rx_desc(struct altera_tse_private *priv,
+ struct tse_buffer *buffer);
+void sgdma_status(struct altera_tse_private *priv);
+u32 sgdma_rx_status(struct altera_tse_private *priv);
+int sgdma_initialize(struct altera_tse_private *priv);
+void sgdma_uninitialize(struct altera_tse_private *priv);
+void sgdma_start_rxdma(struct altera_tse_private *priv);
#endif /* __ALTERA_SGDMA_H__ */
--
2.13.0
next prev parent reply other threads:[~2020-05-04 8:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 8:25 [PATCHv2 00/10] net: eth: altera: tse: Add PTP and mSGDMA prefetcher Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response Joyce Ooi
2020-05-04 17:39 ` David Miller
2020-05-05 9:27 ` Ooi, Joyce
2020-05-04 8:25 ` [PATCHv2 02/10] net: eth: altera: set rx and tx ring size before init_dma call Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 03/10] net: eth: altera: fix altera_dmaops declaration Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 04/10] net: eth: altera: add optional function to start tx dma Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 05/10] net: eth: altera: Move common functions to altera_utils Joyce Ooi
2020-05-04 8:25 ` Joyce Ooi [this message]
2020-05-04 8:25 ` [PATCHv2 07/10] net: eth: altera: change tx functions to type netdev_tx_t Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 08/10] net: eth: altera: add support for ptp and timestamping Joyce Ooi
2020-05-04 16:52 ` Richard Cochran
2020-05-04 8:25 ` [PATCHv2 09/10] net: eth: altera: add msgdma prefetcher Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 10/10] net: eth: altera: update devicetree bindings documentation Joyce Ooi
2020-05-12 22:52 ` Rob Herring
2020-05-13 12:00 ` Ooi, Joyce
2020-05-13 13:00 ` Ooi, Joyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504082558.112627-7-joyce.ooi@intel.com \
--to=joyce.ooi@intel.com \
--cc=chin.liang.see@intel.com \
--cc=dalon.westergreen@intel.com \
--cc=dalon.westergreen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dinh.nguyen@intel.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox