From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A78C47257 for ; Mon, 4 May 2020 16:56:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF758206D9 for ; Mon, 4 May 2020 16:56:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729682AbgEDQ4g (ORCPT ); Mon, 4 May 2020 12:56:36 -0400 Received: from elvis.franken.de ([193.175.24.41]:39547 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728655AbgEDQ4f (ORCPT ); Mon, 4 May 2020 12:56:35 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jVeON-0004p9-00; Mon, 04 May 2020 18:56:31 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id C9E36C036D; Mon, 4 May 2020 18:56:14 +0200 (CEST) Date: Mon, 4 May 2020 18:56:14 +0200 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: "Maciej W. Rozycki" , linux-mips@vger.kernel.org, clang-built-linux@googlegroups.com, Fangrui Song , Kees Cook , Nathan Chancellor , Paul Burton , Masahiro Yamada , Jouni Hogander , Kevin Darbyshire-Bryant , Borislav Petkov , Heiko Carstens , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] MIPS: Truncate link address into 32bit for 32bit kernel Message-ID: <20200504165614.GA15545@alpha.franken.de> References: <20200413062651.3992652-1-jiaxun.yang@flygoat.com> <20200422143258.1250960-1-jiaxun.yang@flygoat.com> <20200504154613.GA14031@alpha.franken.de> <86D4A0AC-59E1-4C82-B66D-6BFC71E08376@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86D4A0AC-59E1-4C82-B66D-6BFC71E08376@flygoat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2020 at 12:09:46AM +0800, Jiaxun Yang wrote: > > 于 2020年5月4日 GMT+08:00 下午11:46:13, Thomas Bogendoerfer 写到: > >On Fri, Apr 24, 2020 at 01:22:30PM +0100, Maciej W. Rozycki wrote: > >> On Thu, 23 Apr 2020, Jiaxun Yang wrote: > >> > >> > > Alternatively, have you made any attempt to verify if actually replacing > >> > >the setting for VMLINUX_LOAD_ADDRESS would be safe? Glancing over its use > >> > >there do not appear to be many places. > >> > > >> > Limited experiments showed it should be fine... > >> > > >> > But MIPS kernel has some design I'm not really familiar with like SYM32 for > >> > 64-bit kernel and special address space design for Trap-and-emul KVM. > >> > >> This only affects CONFIG_32BIT kernels, so SYM32 does not apply; I can't > >> comment on KVM. There's still that bunch of: > >> > >> $(shell expr $(...) \< 0xffffffff80000000) > >> > >> constructs I mentioned before, so let's leave your change as it stands at > >> this time. Please do rename the variable as I suggested though, I hope > >> that's not a big deal. > > > >Jiaxun, are you going to send an update with this change ? > > Sorry my mail server missed Maciej's reply. > > Should I send another version or you just fix it at apply time? please send a new version, thank you. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]