From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34E5EC4724C for ; Mon, 4 May 2020 18:52:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 021EB206B9 for ; Mon, 4 May 2020 18:52:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="YZRAV0Ay" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726530AbgEDSwT (ORCPT ); Mon, 4 May 2020 14:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725981AbgEDSwS (ORCPT ); Mon, 4 May 2020 14:52:18 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D036BC061A0F for ; Mon, 4 May 2020 11:52:16 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id fb4so183418qvb.7 for ; Mon, 04 May 2020 11:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=adjJOFzCV27UBowg1lrxThAfdTSRhfjEwd7jUgPNu98=; b=YZRAV0AyEHZEn9/fI9ik+VuoPT/P7uH/RwqNo+WZMyDbXXmTmjuqh/wcgTIguVa+c1 bIFVoETAloA5UQjrY1t/Yfc0FTqr3a+nbjEYziaQJyOSHpiiJ4aBZk/0mJdq4y4KCR33 shmtfXvKf4ENockWIQs5WA//OxVlh4sPPB2HxV7/sVl9xJIVVWA8YNixo592fT92Cfas hJ9tCF+5zvqTJZqhTzml8lxtP7YqXdJwVZTk++9QxERvZuRmrrwDhT3PTOieWVi0aBgv YflogUvb3JD5DwtGmWyU+2rom/P4nqRfeTbS6gQDm5gdBF2Yh0oJlHNSGV+iDTMyy1O2 Fv1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=adjJOFzCV27UBowg1lrxThAfdTSRhfjEwd7jUgPNu98=; b=ND4yW2ZyX9pg5EXumj33+50lUUYrgU1bPe03RVxPWsOHqFLAYT8EEYxieicnCo7N6R as/bw4M6pXNHPC24lcpYS3z2aLmRjy+W3pQRc41L0Ty2Gb2Ej2Cyk80nj+XR/+6IFbru 26b9kXlEq5NQIuPwnCpUjs+Rz8oxtHQsGAPJ/RdRUFJrmF1jO+j+3xS3NIwTNWAmX7d+ +KbMwm/lxrl5AWulQCSfTHoBZuasBHQPTchGP2fSPIvYIIboJiJ6VNZrm8TxGyJDeUJ3 dJGN0vRmKMkcUTswCLwaNIpSSPCOMEFJwPjI3G9AMlyfFm2nhKe5E4cNELsuNW3BMa0r bqXg== X-Gm-Message-State: AGi0PuZRLZYTPnyyYhulSKYsFWHkRyEe++qUqEPT5CD9gB7mIzmhc64j 8WFtxxJdc0LdHW/ua3kvmT70Bg/O2vI= X-Google-Smtp-Source: APiQypKM1fi3EYDT2GhyOd/rpGfZXDtFNFVhvL1pwgUmcfW72iElR9ef8v/6QtcP0NMRef0SzGen+w== X-Received: by 2002:a05:6214:1386:: with SMTP id g6mr519872qvz.105.1588618335941; Mon, 04 May 2020 11:52:15 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id p75sm3892500qke.121.2020.05.04.11.52.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 May 2020 11:52:15 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jVgCM-00027B-RF; Mon, 04 May 2020 15:52:14 -0300 Date: Mon, 4 May 2020 15:52:14 -0300 From: Jason Gunthorpe To: "Denis V. Lunev" Cc: Konstantin Khorenko , Faisal Latif , Shiraz Saleem , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] i40iw: remove bogus call to netdev_master_upper_dev_get Message-ID: <20200504185214.GA8086@ziepe.ca> References: <20200428131511.11049-1-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428131511.11049-1-den@openvz.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 04:15:11PM +0300, Denis V. Lunev wrote: > Local variable netdev is not used in these calls. > > It should be noted, that this change is required to work in bonded mode. > In the other case we would get the following assert: > "RTNL: assertion failed at net/core/dev.c (5665)" > with the calltrace as follows: > dump_stack+0x19/0x1b > netdev_master_upper_dev_get+0x61/0x70 > i40iw_addr_resolve_neigh+0x1e8/0x220 > i40iw_make_cm_node+0x296/0x700 > ? i40iw_find_listener.isra.10+0xcc/0x110 > i40iw_receive_ilq+0x3d4/0x810 > i40iw_puda_poll_completion+0x341/0x420 > i40iw_process_ceq+0xa5/0x280 > i40iw_ceq_dpc+0x1e/0x40 > tasklet_action+0x83/0x140 > __do_softirq+0x125/0x2bb > call_softirq+0x1c/0x30 > do_softirq+0x65/0xa0 > irq_exit+0x105/0x110 > do_IRQ+0x56/0xf0 > common_interrupt+0x16a/0x16a > ? cpuidle_enter_state+0x57/0xd0 > cpuidle_idle_call+0xde/0x230 > arch_cpu_idle+0xe/0xc0 > cpu_startup_entry+0x14a/0x1e0 > start_secondary+0x1f7/0x270 > start_cpu+0x5/0x14 > > Signed-off-by: Denis V. Lunev > CC: Konstantin Khorenko > CC: Faisal Latif > CC: Shiraz Saleem > CC: Doug Ledford > CC: Jason Gunthorpe > CC: linux-rdma@vger.kernel.org > CC: linux-kernel@vger.kernel.org > Acked-by: Shiraz Saleem > drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 -------- > 1 file changed, 8 deletions(-) Applied to for-rc, thanks JAson