From: Jonathan Corbet <corbet@lwn.net>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Christian Brauner <christian@brauner.io>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] samples: fix binderfs sample
Date: Tue, 5 May 2020 09:48:35 -0600 [thread overview]
Message-ID: <20200505094835.47cc2d53@lwn.net> (raw)
In-Reply-To: <20200429080113.wetsjwkfxfrarfvf@wittgenstein>
On Wed, 29 Apr 2020 10:01:13 +0200
Christian Brauner <christian.brauner@ubuntu.com> wrote:
> On Tue, Apr 28, 2020 at 11:25:33PM +0200, Arnd Bergmann wrote:
> > A routine check for misspelled Kconfig symbols showed on instance
> > from last year, the correct symbol name is CONFIG_ANDROID_BINDERFS,
> > not CONFIG_CONFIG_ANDROID_BINDERFS, so the extra prefix must
> > be removed in the Kconfig file to allow enabling the sample.
> >
> > As the actual sample fails to build as a kernel module, change the
> > Makefile enough to get to build as a hostprog instead.
> >
> > Fixes: 9762dc1432e1 ("samples: add binderfs sample program")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for fixing this Arnd!
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
>
I've applied this, thanks.
jon
next prev parent reply other threads:[~2020-05-05 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 21:25 [PATCH] samples: fix binderfs sample Arnd Bergmann
2020-04-29 3:53 ` Masahiro Yamada
2020-04-29 8:01 ` Christian Brauner
2020-05-05 15:48 ` Jonathan Corbet [this message]
2020-05-05 23:54 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505094835.47cc2d53@lwn.net \
--to=corbet@lwn.net \
--cc=arnd@arndb.de \
--cc=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox