From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE00C47254 for ; Tue, 5 May 2020 14:15:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74FD72083B for ; Tue, 5 May 2020 14:15:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SGdpEVbP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729284AbgEEOPx (ORCPT ); Tue, 5 May 2020 10:15:53 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:21065 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729939AbgEEOPr (ORCPT ); Tue, 5 May 2020 10:15:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588688146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pdh8PaKKCB6jydt3X9bRNYULYYUuebIi6pG6NH9E+WA=; b=SGdpEVbPEAjN3SCEYVeQkqTns2vgKa79DxnAe2GNy5jhLHw8BozivequjrM9KX/z1f5VEu HXH2NExUKS1PZ7FXyWl423eYl2XSDT+9i4VPX3s1Ztj1WwiMq3T2HSXutQFwFUv3KCtKmM QUbUIMD3ckKcoQcwU2jT5bXBwGl6MSA= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-pU2HBKlgNHmvixV7kj_Yig-1; Tue, 05 May 2020 10:15:44 -0400 X-MC-Unique: pU2HBKlgNHmvixV7kj_Yig-1 Received: by mail-qt1-f198.google.com with SMTP id d35so1762652qtc.20 for ; Tue, 05 May 2020 07:15:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Pdh8PaKKCB6jydt3X9bRNYULYYUuebIi6pG6NH9E+WA=; b=ODSCNeOxG7xlsqbhcVtYWEYEGQU5+aGx3o4zvYliGB0/HqV5dQFSs1D9qsYCmqCnlF MZMYsAALrjLjlRng3teNEssILWfkCNL8HK63swVIrcJoXdbNDwRdR+slAZZnRPxoy4To 8SeNwujTBm99a2r16L2frtYDsS7SIQ/QTuT3Lu9bs+ETjwyC1OEk0JuDqjdch93OZp+3 xztzVlpI6azyFDB07ivGqT8z0ggr4iE6feUB5YVJVsJU9/90kdJmV6PSATyfTEnv+HGR ueiRED1bcGvpXL6Dc4CFrVLubbz/773cWontA8jSXJojz0xaUaPONB03LhOoUGqY6pmG +7uQ== X-Gm-Message-State: AGi0PubIX9nEnjs5w+yCeaTc1TTQyK4NAfVRW/zjh3f7Qom5TrZjLQfP 8E1iFShaMwNK+tWpTb7FknP3sGiTA3tiYJuWQgdN83oVBySTfu17JeQJuyrKPu0T3Tc4FU4dI+F 2c7c4bu0dqOYr6+PbSFdxpTxF X-Received: by 2002:aed:3eca:: with SMTP id o10mr2829914qtf.30.1588688143991; Tue, 05 May 2020 07:15:43 -0700 (PDT) X-Google-Smtp-Source: APiQypI7Nwwnxis/I/GyVehDFWGlPcQsyscfxDqmFgtIZNy/E6RdlTN/1qONlWTO6ejDKf2kO4H/Dg== X-Received: by 2002:aed:3eca:: with SMTP id o10mr2829897qtf.30.1588688143786; Tue, 05 May 2020 07:15:43 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id h25sm1921298qte.37.2020.05.05.07.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2020 07:15:42 -0700 (PDT) Date: Tue, 5 May 2020 10:15:41 -0400 From: Peter Xu To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jmattson@google.com Subject: Re: [PATCH] KVM: x86: fix DR6 delivery for emulated hardware breakpoint Message-ID: <20200505141541.GI6299@xz-x1> References: <20200505113449.18478-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200505113449.18478-1-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2020 at 07:34:49AM -0400, Paolo Bonzini wrote: > Go through kvm_queue_exception_p so that the payload is correctly delivered > through the exit qualification, and add a kvm_update_dr6 call to > kvm_deliver_exception_payload that is needed on AMD. > > Signed-off-by: Paolo Bonzini I still think we could also change this in handle_exception_nmi() and handle_dr() as mentioned in the other thread, but no strong opinion: Reviewed-by: Peter Xu Thanks, -- Peter Xu