From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12CFAC47254 for ; Tue, 5 May 2020 15:04:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB1BD20675 for ; Tue, 5 May 2020 15:04:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729885AbgEEPEb (ORCPT ); Tue, 5 May 2020 11:04:31 -0400 Received: from foss.arm.com ([217.140.110.172]:42692 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729324AbgEEPEa (ORCPT ); Tue, 5 May 2020 11:04:30 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 294CF31B; Tue, 5 May 2020 08:04:30 -0700 (PDT) Received: from bogus (unknown [10.37.12.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 195943F68F; Tue, 5 May 2020 08:04:27 -0700 (PDT) Date: Tue, 5 May 2020 16:04:21 +0100 From: Sudeep Holla To: Arnd Bergmann Cc: Peng Fan , Marc Zyngier , Steven Price , Will Deacon , Catalin Marinas , Sudeep Holla , Mark Rutland , linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: fix psci dependency Message-ID: <20200505150421.GA23612@bogus> References: <20200505140820.536615-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505140820.536615-1-arnd@arndb.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Tue, May 05, 2020 at 04:08:08PM +0200, Arnd Bergmann wrote: > When CONFIG_ARM_PSCI_FW is disabled but CONFIG_HAVE_ARM_SMCCC is enabled, > arm-scmi runs into a link failure: > > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/smc.o: in function `smc_send_message': > smc.c:(.text+0x200): undefined reference to `arm_smccc_1_1_get_conduit' > > Use an inline helper to default to version v1.0 in the absence of psci. > Thanks for fixing this. I was thinking if we can separate PSCI and SMCCC quickly as a fix for this but I think he needs to be discussed in detail. I am fine with this fix as is and happy to apply to my tree if no one objects. Sorry but taking this patch as opportunity to discuss how to carry the dependency in future. Just a proposal, 1. Introduce a DT node for SMCCC v1.2+ 2. The new SMCCC driver(strictly speaking library/few APIs) can probe independent of PSCI if DT node is present 3. Else we fallback on PSCI and detect the SMCCC version for v1.1 and v1.2 4. Assume v1.0 if a. PSCI FEATURE returns NOT_SUPPORTED for ARM_SMCCC_VERSION_FUNC_ID b. CONFIG_ARM_PSCI{,_FW} is not defined Mark/Will/Marc, Any other use-case config missed above ? -- Regards, Sudeep