public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: "Bruno Thomsen" <bruno.thomsen@gmail.com>,
	"Per Nørgaard Christensen" <per.christensen@prevas.dk>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: battery switch-over detection on pcf2127
Date: Tue, 5 May 2020 22:07:44 +0200	[thread overview]
Message-ID: <20200505200744.GV34497@piout.net> (raw)
In-Reply-To: <a0ed6b56-33b1-b5ab-00d1-268fcd61b754@prevas.dk>

On 05/05/2020 21:54:47+0200, Rasmus Villemoes wrote:
> Hi Bruno
> 
> I just noticed your "rtc: pcf2127: add tamper detection support"
> (03623b4b04) from 5.4. Unfortunately, clearing the BTSE bit breaks a use
> case of ours:
> 
> We rely on the battery switch-over detection to distinguish a powerfail
> during boot from a PORESET by the external watchdog (in the latter case,
> the RTC is still powered throughout, meaning there is no battery
> switch-over event). OTOH, we do not use the tamper detection - in fact,
> the TS signal is unconnected on our board.
> 
> We're currently still on 4.19, but we will eventually upgrade to a
> kernel containing the above commit. So I was wondering if we could
> figure out a way that would work for both of us - either some CONFIG
> knob, or perhaps something in the device-tree. Any ideas?
> 

Yes, I was working on a patch series last week allowing to read BF. I'm
not sure clearing BTSE is your issue but clearing BF is.

I'm going to send it tonight, I'll copy you, let me now if that works
for you. You can then read BF using the RTC_VL_READ ioctl. The
RTC_VL_BACKUP_SWITCH flag will be set if a switchover happened.
The RTC_VL_CLR ioctl can be used to clear the flag.

I think clearing BTSE is still the right thing to do.

Regards,

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-05-05 20:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 19:54 battery switch-over detection on pcf2127 Rasmus Villemoes
2020-05-05 20:07 ` Alexandre Belloni [this message]
2020-05-05 20:38   ` Bruno Thomsen
2020-05-05 21:01     ` Rasmus Villemoes
2020-05-05 22:14       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200505200744.GV34497@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=bruno.thomsen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=per.christensen@prevas.dk \
    --cc=rasmus.villemoes@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox