From: Greg KH <gregkh@linuxfoundation.org>
To: "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
andriy.shevchenko@intel.com
Subject: Re: [PATCH] serial: lantiq: Add x86 in Kconfig dependencies for Lantiq serial driver
Date: Wed, 6 May 2020 08:41:48 +0200 [thread overview]
Message-ID: <20200506064148.GA2266968@kroah.com> (raw)
In-Reply-To: <3aa4aac0-a9d2-5ab2-e9c9-c7f3bd16da96@linux.intel.com>
On Wed, May 06, 2020 at 12:49:57PM +0800, Tanwar, Rahul wrote:
>
> On 5/5/2020 10:25 pm, Greg KH wrote:
> > On Mon, May 04, 2020 at 04:03:52PM +0800, Rahul Tanwar wrote:
> >> Lantiq serial driver/IP is reused for a x86 based SoC as well.
> >> Update the Kconfig accordingly.
> >>
> >> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
> >> ---
> >> drivers/tty/serial/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> >> index 0aea76cd67ff..4b0a7b98f8c7 100644
> >> --- a/drivers/tty/serial/Kconfig
> >> +++ b/drivers/tty/serial/Kconfig
> >> @@ -1035,7 +1035,7 @@ config SERIAL_SIFIVE_CONSOLE
> >>
> >> config SERIAL_LANTIQ
> >> bool "Lantiq serial driver"
> >> - depends on LANTIQ
> >> + depends on (LANTIQ || X86) || COMPILE_TEST
> >> select SERIAL_CORE
> >> select SERIAL_CORE_CONSOLE
> >> select SERIAL_EARLYCON
> >> --
> >> 2.11.0
> >>
> > Any reason this can't also be a module?
>
> Thanks a lot for accepting the patch. This driver is also used for
> console during bootup so we always have it as built in.
So no generic kernel images can ever be made for this driver? That's
not good, what about systems that have this serial port but does not
care about the console?
That's just ensuring that it will not be built into any distro kernel
images, I suggest fixing this up please.
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-06 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 8:03 [PATCH] serial: lantiq: Add x86 in Kconfig dependencies for Lantiq serial driver Rahul Tanwar
2020-05-05 14:25 ` Greg KH
2020-05-06 4:49 ` Tanwar, Rahul
2020-05-06 6:41 ` Greg KH [this message]
2020-05-06 7:00 ` Tanwar, Rahul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506064148.GA2266968@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rahul.tanwar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox