From: Sudeep Holla <sudeep.holla@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Peng Fan <peng.fan@nxp.com>, Marc Zyngier <maz@kernel.org>,
Steven Price <steven.price@arm.com>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: fix psci dependency
Date: Wed, 6 May 2020 14:44:53 +0100 [thread overview]
Message-ID: <20200506134438.GA27915@bogus> (raw)
In-Reply-To: <20200505150421.GA23612@bogus>
On Tue, May 05, 2020 at 04:04:21PM +0100, Sudeep Holla wrote:
> Hi Arnd,
>
> On Tue, May 05, 2020 at 04:08:08PM +0200, Arnd Bergmann wrote:
> > When CONFIG_ARM_PSCI_FW is disabled but CONFIG_HAVE_ARM_SMCCC is enabled,
> > arm-scmi runs into a link failure:
> >
> > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/smc.o: in function `smc_send_message':
> > smc.c:(.text+0x200): undefined reference to `arm_smccc_1_1_get_conduit'
> >
> > Use an inline helper to default to version v1.0 in the absence of psci.
> >
>
> Thanks for fixing this. I was thinking if we can separate PSCI and SMCCC
> quickly as a fix for this but I think he needs to be discussed in detail.
>
> I am fine with this fix as is and happy to apply to my tree if no one
> objects.
>
> Sorry but taking this patch as opportunity to discuss how to carry the
> dependency in future. Just a proposal,
>
> 1. Introduce a DT node for SMCCC v1.2+
Sorry for the confusion and the above note might have scared people.
Also I misunderstood some internal discussions we had as part of my
SMCCC SOC_ID series[1]. I realised(rather Mark made me realise) this
SCMI SMC is kind of dependent on PSCI as we reuse the conduit from there.
So for now I will make it depend on PSCI to fix the build temporarily.
Also I will try to work out if we can move HAVE_ARCH_SMCCC to something
like HAVE_ARCH_RAW_SMCCC and use HAVE_ARCH_SMCCC for newer changes that
depend on PSCI for probing and conduit. The legacy SMCCC can then go under
HAVE_ARCH_RAW_SMCCC. This was Mark's suggestion, I will try to work it
out and may be post it as part of my SMCCC SOC_ID series also moving
code under drivers/firmware/smccc
--
Regards,
Sudeep
[1] https://lore.kernel.org/r/20200504092905.10580-1-sudeep.holla@arm.com
next prev parent reply other threads:[~2020-05-06 13:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 14:08 [PATCH] firmware: arm_scmi: fix psci dependency Arnd Bergmann
2020-05-05 15:04 ` Sudeep Holla
2020-05-05 16:21 ` Mark Rutland
2020-05-05 17:09 ` Sudeep Holla
2020-05-05 16:22 ` Will Deacon
2020-05-05 17:13 ` Sudeep Holla
2020-05-06 13:44 ` Sudeep Holla [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-07 14:49 Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506134438.GA27915@bogus \
--to=sudeep.holla@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=peng.fan@nxp.com \
--cc=steven.price@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox