From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152F6C4724C for ; Wed, 6 May 2020 17:41:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3A3F208DB for ; Wed, 6 May 2020 17:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729467AbgEFRlD (ORCPT ); Wed, 6 May 2020 13:41:03 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:37872 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728718AbgEFRlC (ORCPT ); Wed, 6 May 2020 13:41:02 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 6599A803E8; Wed, 6 May 2020 19:40:59 +0200 (CEST) Date: Wed, 6 May 2020 19:40:52 +0200 From: Sam Ravnborg To: Jason Yan Cc: adaplas@gmail.com, b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: i810: use true,false for bool variables Message-ID: <20200506174052.GF19296@ravnborg.org> References: <20200422071826.49038-1-yanaijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422071826.49038-1-yanaijie@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=MOBOZvRl c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=i0EeH86SAAAA:8 a=e5mUnYsNAAAA:8 a=t5bY3fDbLEjA0SOcjXMA:9 a=CjuIK1q_8ugA:10 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2020 at 03:18:26PM +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/video/fbdev/i810/i810_main.c:1969:3-7: WARNING: Assignment of > 0/1 to bool variable > drivers/video/fbdev/i810/i810_main.c:1971:3-8: WARNING: Assignment of > 0/1 to bool variable > drivers/video/fbdev/i810/i810_main.c:1973:3-9: WARNING: Assignment of > 0/1 to bool variable > drivers/video/fbdev/i810/i810_main.c:1975:3-7: WARNING: Assignment of > 0/1 to bool variable > drivers/video/fbdev/i810/i810_main.c:2001:3-9: WARNING: Assignment of > 0/1 to bool variable > > Signed-off-by: Jason Yan Thanks. I have pushed this and your other three patches to drm-misc-next. They will show up in the mainline kernel in the next merge window. Sam > --- > drivers/video/fbdev/i810/i810_main.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c > index aa7583d963ac..13bbf7fe13bf 100644 > --- a/drivers/video/fbdev/i810/i810_main.c > +++ b/drivers/video/fbdev/i810/i810_main.c > @@ -1966,13 +1966,13 @@ static int i810fb_setup(char *options) > > while ((this_opt = strsep(&options, ",")) != NULL) { > if (!strncmp(this_opt, "mtrr", 4)) > - mtrr = 1; > + mtrr = true; > else if (!strncmp(this_opt, "accel", 5)) > - accel = 1; > + accel = true; > else if (!strncmp(this_opt, "extvga", 6)) > - extvga = 1; > + extvga = true; > else if (!strncmp(this_opt, "sync", 4)) > - sync = 1; > + sync = true; > else if (!strncmp(this_opt, "vram:", 5)) > vram = (simple_strtoul(this_opt+5, NULL, 0)); > else if (!strncmp(this_opt, "voffset:", 8)) > @@ -1998,7 +1998,7 @@ static int i810fb_setup(char *options) > else if (!strncmp(this_opt, "vsync2:", 7)) > vsync2 = simple_strtoul(this_opt+7, NULL, 0); > else if (!strncmp(this_opt, "dcolor", 6)) > - dcolor = 1; > + dcolor = true; > else if (!strncmp(this_opt, "ddc3", 4)) > ddc3 = true; > else > -- > 2.21.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel