Re: [PATCH v4 11/11] module: Make module_enable_ro() static again

Guenter Roeck
2020-06-05T13:24:55Z

On Wed, Apr 29, 2020 at 10:24:53AM -0500, Josh Poimboeuf wrote:
> Now that module_enable_ro() has no more external users, make it static
> again.
>
> Suggested-by: Jessica Yu <jeyu@kernel.org>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Acked-by: Miroslav Benes <mbenes@suse.cz>

Apparently this patch made it into the upstream kernel on its own,
not caring about its dependencies. Results are impressive.

Build results:
total: 155 pass: 101 fail: 54
Qemu test results:
total: 431 pass: 197 fail: 234

That means bisects will be all but impossible until this is fixed.
Was that really necessary ?

Guenter