From: Masami Hiramatsu <mhiramat@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Eelco Chaudron <echaudro@redhat.com>, Yonghong Song <yhs@fb.com>,
bpf <bpf@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Andrii Nakryiko <andriin@fb.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Wang Nan <wangnan0@huawei.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/3] x86/kprobes: Support nested kprobes
Date: Fri, 8 May 2020 00:45:56 +0900 [thread overview]
Message-ID: <20200508004556.d968ee87b91dc7940ac161f2@kernel.org> (raw)
In-Reply-To: <158884559505.12656.1357851132314046716.stgit@devnote2>
On Thu, 7 May 2020 18:59:55 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Make kprobes to accept 1-level nesting instead of
> diff --git a/arch/x86/kernel/kprobes/ftrace.c b/arch/x86/kernel/kprobes/ftrace.c
> index 681a4b36e9bb..b695c2e118f8 100644
> --- a/arch/x86/kernel/kprobes/ftrace.c
> +++ b/arch/x86/kernel/kprobes/ftrace.c
> @@ -25,13 +25,15 @@ void kprobe_ftrace_handler(unsigned long ip, unsigned long parent_ip,
> return;
>
> kcb = get_kprobe_ctlblk();
> - if (kprobe_running()) {
> + if (!kprobe_can_nest()) {
Oops, something wrong. this kprobe_can_nest() requires kcb for
the parameter. I'll fix this.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-05-07 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 9:59 [RFC PATCH 0/3] kprobes: Support nested kprobes Masami Hiramatsu
2020-05-07 9:59 ` [RFC PATCH 1/3] x86/kprobes: " Masami Hiramatsu
2020-05-07 15:45 ` Masami Hiramatsu [this message]
2020-05-07 10:00 ` [RFC PATCH 2/3] arm64: kprobes: " Masami Hiramatsu
2020-05-07 10:00 ` [RFC PATCH 3/3] arm: " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508004556.d968ee87b91dc7940ac161f2@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=echaudro@redhat.com \
--cc=kafai@fb.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=wangnan0@huawei.com \
--cc=will@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox