From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC1AC38A24 for ; Thu, 7 May 2020 15:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD18C2082E for ; Thu, 7 May 2020 15:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588866366; bh=MtT1K1QhdR93RnKXEINbJSy9JalbcJDWOmF/snclf4U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=mqCK6lCNwMkSeVV2WHrwvqPC2Re0sDM0SLUvN6k6I+O2D6dOm5KOtuuKlgele4i87 1RURnX0gdtyudzccbI8j0EWrE6Cc/P20DSjqB3qRZ7t7u+A1/hgHIFcK00dCxBM2xH d/FEAYyoeTrfubZo438bHnHPl/bE6CaH6ikndzI8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727769AbgEGPqF (ORCPT ); Thu, 7 May 2020 11:46:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:34928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727086AbgEGPqE (ORCPT ); Thu, 7 May 2020 11:46:04 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A94A0207DD; Thu, 7 May 2020 15:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588866364; bh=MtT1K1QhdR93RnKXEINbJSy9JalbcJDWOmF/snclf4U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ImqSVH0/sYKWxb69Pox8SY+3RRS3M0o9prJxmrXYt8yg5zRTmmeBZywK3+SkqtrL6 E/vnxRTB860fUDJ2IjcmXxXHAZtW7XsQ6S5pE/G3KhhSWAPa9YAoxBy66VhyVAX51N bX1AZ3994AOUMkgIZt+6mf9rmrCoRDcawwBU0ZGQ= Date: Fri, 8 May 2020 00:45:56 +0900 From: Masami Hiramatsu To: Masami Hiramatsu Cc: LKML , Steven Rostedt , Ingo Molnar , Arnaldo Carvalho de Melo , Eelco Chaudron , Yonghong Song , bpf , "David S . Miller" , Network Development , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Andrii Nakryiko , Catalin Marinas , Will Deacon , Wang Nan , Russell King , linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 1/3] x86/kprobes: Support nested kprobes Message-Id: <20200508004556.d968ee87b91dc7940ac161f2@kernel.org> In-Reply-To: <158884559505.12656.1357851132314046716.stgit@devnote2> References: <158884558272.12656.7654266361809594662.stgit@devnote2> <158884559505.12656.1357851132314046716.stgit@devnote2> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 May 2020 18:59:55 +0900 Masami Hiramatsu wrote: > Make kprobes to accept 1-level nesting instead of > diff --git a/arch/x86/kernel/kprobes/ftrace.c b/arch/x86/kernel/kprobes/ftrace.c > index 681a4b36e9bb..b695c2e118f8 100644 > --- a/arch/x86/kernel/kprobes/ftrace.c > +++ b/arch/x86/kernel/kprobes/ftrace.c > @@ -25,13 +25,15 @@ void kprobe_ftrace_handler(unsigned long ip, unsigned long parent_ip, > return; > > kcb = get_kprobe_ctlblk(); > - if (kprobe_running()) { > + if (!kprobe_can_nest()) { Oops, something wrong. this kprobe_can_nest() requires kcb for the parameter. I'll fix this. Thank you, -- Masami Hiramatsu