Re: [PATCH v3 1/3] powerpc/numa: Set numa_node for all possible cpus

Christopher Lameter
2020-05-02T22:55:18Z

On Fri, 1 May 2020, Srikar Dronamraju wrote:

> - for_each_present_cpu(cpu)
> - numa_setup_cpu(cpu);
> + for_each_possible_cpu(cpu) {
> + /*
> + * Powerpc with CONFIG_NUMA always used to have a node 0,
> + * even if it was memoryless or cpuless. For all cpus that
> + * are possible but not present, cpu_to_node() would point
> + * to node 0. To remove a cpuless, memoryless dummy node,
> + * powerpc need to make sure all possible but not present
> + * cpu_to_node are set to a proper node.
> + */
> + if (cpu_present(cpu))
> + numa_setup_cpu(cpu);
> + else
> + set_cpu_numa_node(cpu, first_online_node);
> + }
> }

Can this be folded into numa_setup_cpu?

This looks more like numa_setup_cpu needs to change?