Re: [PATCH v4 14/18] static_call: Add static_cond_call()

Mathieu Desnoyers
2020-05-06T14:01:15Z

----- On May 6, 2020, at 9:55 AM, Peter Zijlstra peterz@infradead.org wrote:

> On Tue, May 05, 2020 at 04:27:44PM -0400, Mathieu Desnoyers wrote:
>> Actually, if the goal is to do code patching of the call, I wonder
>> what makes it OK to "guess" all the call patterns generated by the compiler ?
>
> We're not guessing, have have objtool read the compiler output and
> record the location for us. The compiler can generate whatever it likes.

So is the plan to adapt objtool if future compilers change the generated
instruction patterns ?

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.