Re: [PATCH v4 06/18] static_call: Add basic static call infrastructure

Josh Poimboeuf
2020-05-05T21:21:14Z

On Fri, May 01, 2020 at 10:28:55PM +0200, Peter Zijlstra wrote:
> +++ b/include/linux/static_call_types.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _STATIC_CALL_TYPES_H
> +#define _STATIC_CALL_TYPES_H
> +
> +#include <linux/stringify.h>
> +
> +#define STATIC_CALL_PREFIX __SC__

This should probably be STATIC_CALL_KEY_PREFIX. And change the prefix
to __SCK__ for consistency?

> +#define STATIC_CALL_KEY(name) __PASTE(STATIC_CALL_PREFIX, name)
> +
> +#define STATIC_CALL_TRAMP_PREFIX __SCT__
> +#define STATIC_CALL_TRAMP_PREFIX_STR __stringify(STATIC_CALL_TRAMP_PREFIX)
> +#define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
> +#define STATIC_CALL_TRAMP_STR(name) __stringify(STATIC_CALL_TRAMP(name))

--
Josh