From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF8BC4724C for ; Fri, 8 May 2020 14:56:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD2C32173E for ; Fri, 8 May 2020 14:56:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbgEHO4i (ORCPT ); Fri, 8 May 2020 10:56:38 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2176 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726690AbgEHO4i (ORCPT ); Fri, 8 May 2020 10:56:38 -0400 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 5C856535883A350AC80C; Fri, 8 May 2020 15:56:36 +0100 (IST) Received: from localhost (10.47.95.97) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 8 May 2020 15:56:35 +0100 Date: Fri, 8 May 2020 15:56:13 +0100 From: Jonathan Cameron To: Gwendal Grignou CC: , , , , , Subject: Re: [PATCH v3 0/3] iio: cros_ec: Add support for RGB light sensor Message-ID: <20200508155613.00005c95@Huawei.com> In-Reply-To: <20200506230324.139241-1-gwendal@chromium.org> References: <20200506230324.139241-1-gwendal@chromium.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.95.97] X-ClientProxiedBy: lhreml743-chm.china.huawei.com (10.201.108.193) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 May 2020 16:03:21 -0700 Gwendal Grignou wrote: > Add support for color light sensor presented by the Chromebook Embedded > Controller (EC). > Instead of just presenting lux measurement (clear channel), a color light > sensor is able to report color temperature measurement. > > The EC, using factory settings, can transform the raw measurement into > the CIE 1931 XYZ color space (XYZ) and take adavantage of color sensor > autocalibration to provide the most accurate measurements. v3 of series with v2 patches? Also my earlier comment about colour channels cannot be illuminance still stands. It is a term that "only" applies to light measurements with a particular frequency / sensitivity curve. The colour channels should all be in_intensity_xxx_raw. If you want to do the computation in driver to derive the illuminance that would be great, otherwise we shouldn't have any illuminance channels. Jonathan > > Gwendal Grignou (3): > iio: Add in_illumincance vectors in different color spaces > iio: cros_ec: Allow enabling/disabling calibration mode > iio: cros_ec_light: Add support for RGB sensor > > Documentation/ABI/testing/sysfs-bus-iio | 27 + > .../cros_ec_sensors/cros_ec_sensors_core.c | 3 +- > drivers/iio/light/cros_ec_light_prox.c | 469 +++++++++++++++--- > drivers/platform/chrome/cros_ec_sensorhub.c | 3 + > .../linux/iio/common/cros_ec_sensors_core.h | 1 - > .../linux/platform_data/cros_ec_commands.h | 14 +- > 6 files changed, 441 insertions(+), 76 deletions(-) >