From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FD7EC38A2A for ; Fri, 8 May 2020 23:47:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 366252173E for ; Fri, 8 May 2020 23:47:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728348AbgEHXrF (ORCPT ); Fri, 8 May 2020 19:47:05 -0400 Received: from mga17.intel.com ([192.55.52.151]:21510 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727774AbgEHXrF (ORCPT ); Fri, 8 May 2020 19:47:05 -0400 IronPort-SDR: qQAqKWwTDYPRUoHQD8UvVll2IubdOOpf2jXRhXwl5mbcivkMqCEyDrDy5VszM79VR9qwdEi4Rn Rc81C4UzM+sA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 16:47:04 -0700 IronPort-SDR: IgmrIChEafSOPxXY/UYw1Y2kWVyxeCtNJby66alTB8gI1u7A6peCARaxk9T6+QycGiiMk5J9/a peFREwyRD8Lg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,369,1583222400"; d="scan'208";a="279186642" Received: from jbrandeb-mobl2.amr.corp.intel.com (HELO localhost) ([10.212.217.221]) by orsmga002.jf.intel.com with SMTP; 08 May 2020 16:47:03 -0700 Date: Fri, 8 May 2020 16:47:03 -0700 From: Jesse Brandeburg To: Nathan Chancellor Cc: Nick Desaulniers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Sedat Dilek , "kernelci . org bot" , Andy Shevchenko , Brian Gerst , "H . Peter Anvin" , "Ilie Halip" , , Marco Elver , "Paul E. McKenney" , Andrey Ryabinin , Luc Van Oostenryck , Andrew Morton , Masahiro Yamada , Daniel Axtens , "Peter Zijlstra (Intel)" , , Subject: Re: [PATCH v5] x86: bitops: fix build regression Message-ID: <20200508164703.0000481d@intel.com> In-Reply-To: <20200508202835.GA550540@ubuntu-s3-xlarge-x86> References: <20200508182835.228107-1-ndesaulniers@google.com> <20200508183230.229464-1-ndesaulniers@google.com> <20200508202835.GA550540@ubuntu-s3-xlarge-x86> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 May 2020 13:28:35 -0700 Nathan Chancellor wrote: > On Fri, May 08, 2020 at 11:32:29AM -0700, Nick Desaulniers wrote: > > Use the `%b` "x86 Operand Modifier" to instead force register allocation > > to select a lower-8-bit GPR operand. This looks OK to me, I appreciate the work done to find the right fix and clean up the code while not breaking sparse! I had a look at the assembly from gcc 9.3.1 and it looks good. Thanks! Reviewed-by: Jesse Brandeburg