From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C132C38A2A for ; Fri, 8 May 2020 21:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 548C6217BA for ; Fri, 8 May 2020 21:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588972259; bh=qqkVr4kTP0XXZVP5xFbn1niXGfNe06721rm6KoYrYkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vHtAC1g6lJQXYCxUDEzu5bvzo2BDOKarIl+adMC4DcYf38f/0u+rFwcU63+t6ugak 9/ov+Xju/Uepgh8yR256VMHzoelq4hs5oNHeZd2H7afKe4a4SGz+GGqli6eX8CNI5i jn8ANG6hQsKfHybpdKTlITFxy5u/J1TUbp5VNvow= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728109AbgEHVK6 (ORCPT ); Fri, 8 May 2020 17:10:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:46126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726913AbgEHVK6 (ORCPT ); Fri, 8 May 2020 17:10:58 -0400 Received: from embeddedor (unknown [189.207.59.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31DCB2173E; Fri, 8 May 2020 21:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588972257; bh=qqkVr4kTP0XXZVP5xFbn1niXGfNe06721rm6KoYrYkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qOzEFrdYz4YFcUHf49CJNi5f+sr73JPUOQI3aOAdobR3CsvYuEjo+/oWD/KiOaP8z IuVw3ckU8nlAcMVQNCd4/X77zD3VtuOZzCvnHHTbk6C96q6/E3yH/6rD3Mxwm42C2B tHqidnAS9xxjOGCQAVjSPsEha1GnutMIYT5rtV1k= Date: Fri, 8 May 2020 16:15:25 -0500 From: "Gustavo A. R. Silva" To: Paul Moore Cc: "Gustavo A. R. Silva" , Eric Paris , linux-audit@redhat.com, linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH] audit: mark expected switch fall-through Message-ID: <20200508211525.GE23375@embeddedor> References: <20190212204600.GA24049@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 12, 2019 at 08:19:44PM -0500, Paul Moore wrote: > On Tue, Feb 12, 2019 at 3:46 PM Gustavo A. R. Silva > wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > cases where we are expecting to fall through. > > > > This patch fixes the following warning: > > > > kernel/auditfilter.c: In function ‘audit_krule_to_data’: > > kernel/auditfilter.c:668:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > > if (krule->pflags & AUDIT_LOGINUID_LEGACY && !f->val) { > > ^ > > kernel/auditfilter.c:674:3: note: here > > default: > > ^~~~~~~ > > > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > > > Notice that, in this particular case, the code comment is modified > > in accordance with what GCC is expecting to find. > > > > This patch is part of the ongoing efforts to enable > > -Wimplicit-fallthrough. > > > > Signed-off-by: Gustavo A. R. Silva > > --- > > kernel/auditfilter.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Merged into audit/next, thanks. > Thanks, Paul. -- Gustavo