From: Helge Deller <deller@gmx.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parisc: suppress error messages for 'make clean'
Date: Fri, 8 May 2020 23:46:50 +0200 [thread overview]
Message-ID: <20200508214650.GA3482@ls3530.fritz.box> (raw)
In-Reply-To: <CAK7LNAQk_fLFCWuFCC0NK3nxVE0bs-n7E+T-dbn14aCZVg_pgQ@mail.gmail.com>
* Masahiro Yamada <masahiroy@kernel.org>:
> On Sat, Apr 25, 2020 at 2:47 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > 'make ARCH=parisc clean' emits a tons of error messages as follows:
> >
> > $ make ARCH=parisc clean
> > gcc: error: unrecognized command line option '-mno-space-regs'
> > gcc: error: unrecognized command line option '-mfast-indirect-calls'; did you mean '-mforce-indirect-call'?
> > gcc: error: unrecognized command line option '-mdisable-fpregs'
> > gcc: error: missing argument to '-Wframe-larger-than='
> > gcc: error: unrecognized command line option '-mno-space-regs'
> > gcc: error: unrecognized command line option '-mfast-indirect-calls'; did you mean '-mforce-indirect-call'?
> > gcc: error: unrecognized command line option '-mdisable-fpregs'
> > gcc: error: missing argument to '-Wframe-larger-than='
> > ...
> >
> > You can supporess them except '-Wframe-larger-than' by setting correct
> > CROSS_COMPILE=, but we should not require any compiler for cleaning.
> >
> > This $(shell ...) is evaluated so many times because LIBGCC is exported.
> > Use the ':=' operator to evaluate it just once, and sink the stderr.
> >
>
> Applied to linux-kbuild.
That patch breaks then building the boot loader/compressor:
...
hppa-linux-gnu-ld -X -e startup --as-needed -T arch/parisc/boot/compressed/vmlinux.lds arch/parisc/boot/compressed/head.o arch/parisc/boot/compressed/real2.o arch/parisc/boot/compressed/firmware.o arch/parisc/boot/compressed/misc.o arch/parisc/boot/compressed/piggy.o -o arch/parisc/boot/compressed/vmlinux
hppa-linux-gnu-ld: arch/parisc/boot/compressed/misc.o: in function `dec_vli':
(.text+0x104): undefined reference to `__ashldi3'
hppa-linux-gnu-ld: arch/parisc/boot/compressed/misc.o: in function `lzma_len':
(.text+0x2b0): undefined reference to `$$mulI'
hppa-linux-gnu-ld: (.text+0x344): undefined reference to `$$mulI'
hppa-linux-gnu-ld: (.text+0x3f8): undefined reference to `$$mulI'
The patch below works, but I wonder if it's possible to avoid
to examine LIBGCC twice....?
Helge
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 628cd8bb7ad8..aeea20abbf01 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -21,8 +21,7 @@ KBUILD_IMAGE := vmlinuz
NM = sh $(srctree)/arch/parisc/nm
CHECKFLAGS += -D__hppa__=1
-LIBGCC = $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
-export LIBGCC
+LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
ifdef CONFIG_64BIT
UTS_MACHINE := parisc64
diff --git a/arch/parisc/boot/compressed/Makefile b/arch/parisc/boot/compressed/Makefile
index 1e5879c6a752..b008cf1b5c1e 100644
--- a/arch/parisc/boot/compressed/Makefile
+++ b/arch/parisc/boot/compressed/Makefile
@@ -22,6 +22,8 @@ ifndef CONFIG_64BIT
KBUILD_CFLAGS += -mfast-indirect-calls
endif
+LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
+
OBJECTS += $(obj)/head.o $(obj)/real2.o $(obj)/firmware.o $(obj)/misc.o $(obj)/piggy.o
LDFLAGS_vmlinux := -X -e startup --as-needed -T
next prev parent reply other threads:[~2020-05-08 21:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 5:46 [PATCH] parisc: suppress error messages for 'make clean' Masahiro Yamada
2020-05-01 5:35 ` Masahiro Yamada
2020-05-08 21:46 ` Helge Deller [this message]
2020-05-09 8:16 ` Masahiro Yamada
2020-05-09 17:39 ` Helge Deller
2020-05-10 1:19 ` Masahiro Yamada
2020-05-10 20:28 ` Helge Deller
2020-06-13 19:36 ` Rolf Eike Beer
2020-06-13 22:48 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508214650.GA3482@ls3530.fritz.box \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox