From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F098C38A2A for ; Fri, 8 May 2020 23:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04EA321974 for ; Fri, 8 May 2020 23:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588981037; bh=TTmQy61+zMJ0ALWgDCPYoVDJHD0JlRbB+Qz6kqRgTT8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RBlDZgW4cth7XWXNAX5PjEOIUZhJCH91EgjGtiOKB6tVaZCI6j5YaVN89/BCiE+L6 NKDQVakHB6NXlWnVOd3X10dr5Sb+C5LODSusQKfMHZGpHQsPNzFGUzhVAXS/dpDHTy 32vHyK9lyQLJcyJsMvrF6ZNcSaTTTrh5WUIrZbqU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728324AbgEHXhP (ORCPT ); Fri, 8 May 2020 19:37:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:59310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727878AbgEHXhO (ORCPT ); Fri, 8 May 2020 19:37:14 -0400 Received: from embeddedor (unknown [189.207.59.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3242621974; Fri, 8 May 2020 23:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588981034; bh=TTmQy61+zMJ0ALWgDCPYoVDJHD0JlRbB+Qz6kqRgTT8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J7LKO1YUXULcfyT7oCMVxpJm4O43hQ5MepZs+5JNDLT0UoYdHOJO/0YBOi0ajI8F8 kzSFFvVY6WVPPt9hvhYBYL6tJXPEImQaIdTxPqFzrofjdAEic9WB3Slxj6TRrXCBcm THk1XoB/eUnT1lnJb/Tz24SWWPKq37jGCdPq6J3A= Date: Fri, 8 May 2020 18:41:42 -0500 From: "Gustavo A. R. Silva" To: Linus Torvalds Cc: Linux Kernel Mailing List , Kees Cook Subject: Re: [PATCH] efi: Replace zero-length array with flexible-array Message-ID: <20200508234142.GA27139@embeddedor> References: <20200507192712.GA16805@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 10:26:40AM -0700, Linus Torvalds wrote: > On Thu, May 7, 2020 at 12:22 PM Gustavo A. R. Silva > wrote: > > > > The current codebase makes use of the zero-length array language > > extension to the C90 standard, but the preferred mechanism to declare > > variable-length types such as these ones is a flexible array member[1][2], > > introduced in C99 [...] > > Why is this called an "efi" patch, when it doesn't appear to be so at all: > > > include/linux/dma/ti-cppi5.h | 4 ++-- > > include/linux/efi.h | 2 +- > > include/linux/mailbox/zynqmp-ipi-message.h | 2 +- > > include/linux/platform_data/cros_ec_commands.h | 4 ++-- > > include/linux/platform_data/cros_ec_proto.h | 2 +- > > kernel/params.c | 2 +- > > kernel/tracepoint.c | 2 +- > > scripts/kallsyms.c | 2 +- > > 8 files changed, 10 insertions(+), 10 deletions(-) > > Yes, one line of the patch is EFI code. The rest are not. > Yeah. It seems the script needs some improvement. I'll split this patch up into multiple patches. Thanks -- Gustavo