Re: [EXT] [PATCH 09/15] qed: use new module_firmware_crashed()

Luis Chamberlain
2020-05-15T20:32:35Z

On Thu, May 14, 2020 at 05:53:41PM +0300, Igor Russkikh wrote:
> >
> > So do you mean like the changes below?
> >
> > diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c
> > b/drivers/net/ethernet/qlogic/qed/qed_debug.c
> > index f4eebaabb6d0..95cb7da2542e 100644
> > --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
> > +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
> > @@ -7906,6 +7906,7 @@ int qed_dbg_all_data(struct qed_dev *cdev, void
> > *buffer)
> > rc = qed_dbg_grc(cdev, (u8 *)buffer + offset +
> > REGDUMP_HEADER_SIZE, &feature_size);
> > if (!rc) {
> > + module_firmware_crashed();
> > *(u32 *)((u8 *)buffer + offset) =
> > qed_calc_regdump_header(cdev, GRC_DUMP,
> > cur_engine,
>
> Please remove this invocation. Its not a place where FW crash is happening.

Will do!

>
> > DP_NOTICE(p_hwfn,
> > "The MFW failed to respond to command 0x%08x
> > [param 0x%08x].\n",
> > p_mb_params->cmd, p_mb_params->param);
> > + module_firmware_crashed();
> > qed_mcp_print_cpu_info(p_hwfn, p_ptt);
>
> This one is perfect, thanks!

Can I add your Reviewed-by provided I remove the hunk above?

Luis