From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matej Dujava <mdujava@kocurkovo.cz>
Cc: Forest Bond <forest@alittletooquiet.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6656: vt6655: clean Makefiles
Date: Sat, 9 May 2020 19:07:14 +0200 [thread overview]
Message-ID: <20200509170714.GC2482887@kroah.com> (raw)
In-Reply-To: <1589015247-738-1-git-send-email-mdujava@kocurkovo.cz>
On Sat, May 09, 2020 at 11:07:27AM +0200, Matej Dujava wrote:
> This patch is removing CFLAGS that are defining flags that are not used.
You are also modifying the indentation and moving lines around for no
reason :(
Please only do one thing for a patch, and always describe everything you
do in the changelog text.
Can you fix this up and send a v2?
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-09 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 9:07 [PATCH] staging: vt6656: vt6655: clean Makefiles Matej Dujava
2020-05-09 17:07 ` Greg Kroah-Hartman [this message]
2020-05-09 19:30 ` Matej Dujava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509170714.GC2482887@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mdujava@kocurkovo.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox