Re: [PATCH net v3] hinic: fix a bug of ndo_stop

Jakub Kicinski
2020-05-11T03:08:00Z

On Sun, 10 May 2020 19:01:08 +0000 Luo bin wrote:
> if some function in ndo_stop interface returns failure because of
> hardware fault, must go on excuting rest steps rather than return
> failure directly, otherwise will cause memory leak.And bump the
> timeout for SET_FUNC_STATE to ensure that cmd won't return failure
> when hw is busy. Otherwise hw may stomp host memory if we free
> memory regardless of the return value of SET_FUNC_STATE.
>
> Fixes: 51ba902a16e6 ("net-next/hinic: Initialize hw interface")
> Signed-off-by: Luo bin <luobin9@huawei.com>

Applied, thank you.