From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90617C47255 for ; Mon, 11 May 2020 07:42:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67A5A2082E for ; Mon, 11 May 2020 07:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589182960; bh=FJcK6HYgmWFsakci+77EzjxC0EBy2+zIQXMTQsRo66w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=k/9eDBxeozyVV4OHe9T9eDKsQ5aoSWvfC6rDb7gLgswSfFDIAPGs2Pyn2qJQlgnDq Zo7igRnv1S8nSbUTRdxqTSqu77dqcOVMnUm06wQyVSTcK0+cMvRl4tOWXA7x2Xjuxc wBHtjeHRSl7kZAucEm93jCP8URkldOfX58/nRIZA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728750AbgEKHmj (ORCPT ); Mon, 11 May 2020 03:42:39 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:34707 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbgEKHmi (ORCPT ); Mon, 11 May 2020 03:42:38 -0400 Received: by mail-ed1-f66.google.com with SMTP id g16so7092435eds.1; Mon, 11 May 2020 00:42:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/gXH+5V1OhGf0lDZmtXQexZA4f2X1Oj6FaM9kDcTW/I=; b=ZeZp81hwEkHzXkM14meH3JDyv90Ch65oWXzz64DzX9gOUkncpOVcllBjSqsOnoWNjo Nk6Srr5SJ+7gJrD8Vf0q2FLACQlCl7bH6YJufWpssG+dx6juVRIYWi4I1z+PpET1lFnU pXp6Q/4Jh/0niE1fgaXjFm8sXfXsRG7PxUi91riLjrHHtq5P8sazeoE+7rphMec2pKTO E2aeCNsNEJnK5Jz7oI3oUC3NcBtlKBaFhOhb07wLCeDVUCgeHLXZlXbu5iqC8LLpWQ/J ZtT7sMcUgAkUbVmRN9LISrqM+lCk9JKWPRHVXuDpwT+MjFfRNJPy+8nhnc12VZdW40we uFVQ== X-Gm-Message-State: AGi0PuZCW9LGR9hHNFDQlDHwjmz0MR7Sp33CmhgVTe1GVze3F1XWu0Ho lLRdAb6EkKEIi+Vs1v/xvy0= X-Google-Smtp-Source: APiQypKNXJxBqeWKUcQZCLy5hhnnh16d804wT763ceEEJlpi/zqQEfidD1ZPGObtTh2DAv0fOSjHSw== X-Received: by 2002:a05:6402:1d23:: with SMTP id dh3mr12214214edb.349.1589182956149; Mon, 11 May 2020 00:42:36 -0700 (PDT) Received: from kozik-lap ([194.230.155.237]) by smtp.googlemail.com with ESMTPSA id g20sm1194769ejb.41.2020.05.11.00.42.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 May 2020 00:42:35 -0700 (PDT) Date: Mon, 11 May 2020 09:42:32 +0200 From: Krzysztof Kozlowski To: Jonathan Cameron Cc: Jonathan Bakker , knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, kgene@kernel.org, cw00.choi@samsung.com, kstewart@linuxfoundation.org, mpe@ellerman.id.au, m.szyprowski@samsung.com, swboyd@chromium.org, tglx@linutronix.de, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: Add scaling support to exynos adc driver Message-ID: <20200511074232.GA7134@kozik-lap> References: <20200510112417.1e54d66e@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200510112417.1e54d66e@archlinux> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 10, 2020 at 11:24:17AM +0100, Jonathan Cameron wrote: > On Fri, 8 May 2020 14:14:00 -0700 > Jonathan Bakker wrote: > > > Currently the driver only exposes the raw counts. As we > > have the regulator voltage and the maximum value (stored in > > the data mask), we can trivially produce a scaling fraction > > of voltage / max value. > > > > This assumes that the regulator voltage is in fact the max > > voltage, which appears to be the case for all mainline dts > > and cross referenced with the public Exynos4412 and S5PV210 > > datasheets. > > > > Signed-off-by: Jonathan Bakker > > Seems reasonable to me. I'd like an exynos Ack though before applying. It's correct, at least with ARMv7 Exynos datasheets The few ARMv8 Exynos chips are silent about the voltage levels. The Exynos 7 DTS board in mainline kernel does not have regulator but it looks clearly like mistake. I think they behave the same, so for Exynos: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > thanks, > > Jonathan > >