Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id()

Russell King - ARM Linux admin
2020-05-05T14:21:26Z

On Tue, May 05, 2020 at 05:15:16PM +0300, Andy Shevchenko wrote:
> On Tue, May 5, 2020 at 4:29 PM Calvin Johnson
> > + if (sscanf(cp, "ethernet-phy-id%4x.%4x",
> > + &upper, &lower) == 2) {
>
> > + *phy_id = ((upper & 0xFFFF) << 16) | (lower & 0xFFFF);
>
> How upper can be bigger than 0xfff? Same for lower.

I think your comment is incorrect here. Four hex digits can be larger
than 0xfff. "1000" interpreted as hex is four hex digits and larger
than 0xfff, for example.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up