Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id()

Andy Shevchenko
2020-05-07T17:27:53Z

On Thu, May 7, 2020 at 4:26 PM Jeremy Linton <jeremy.linton@arm.com> wrote:
> On 5/5/20 8:29 AM, Calvin Johnson wrote:

> > + if (sscanf(cp, "ethernet-phy-id%4x.%4x",
> > + &upper, &lower) == 2) {
> > + *phy_id = ((upper & 0xFFFF) << 16) | (lower & 0xFFFF);
> > + return 0;
> > + }

> Isn't the ACPI _CID() conceptually similar to the DT compatible
> property?

Where?

> It even appears to be getting used in a similar way to
> identify particular phy drivers in this case.

_CID() is a string. It can't be used as pure number.

--
With Best Regards,
Andy Shevchenko