Re: [PATCH v2 2/3] powerpc/numa: Prefer node id queried from vphn

Srikar Dronamraju
2020-04-30T04:35:13Z

* Gautham R Shenoy <ego@linux.vnet.ibm.com> [2020-04-29 12:22:29]:

> Hello Srikar,
>
>
> > + if (nid == NUMA_NO_NODE) {
> > + cpu = of_get_cpu_node(i, NULL);
> > + if (cpu) {
>
> Why are we not retaining the BUG_ON(!cpu) assert here ?
>
> > + nid = of_node_to_nid_single(cpu);
> > + of_node_put(cpu);
> > + }
> > + }
>
> Is it possible at this point that both vphn_get_nid(i) and
> of_node_to_nid_single(cpu) returns NUMA_NO_NODE ? If so,
> should we still call node_set_online() below ?

Yeah, I think It makes sense to retain the BUG_ON and if check.

Will incorporate both of them in the next version.

>
>
> > node_set_online(nid);
> > }
> >
> > --
> > 2.20.1
> >
> --
> Thanks and Regards
> gautham.

--
Thanks and Regards
Srikar Dronamraju