Re: [PATCH v7 1/7] dt-bindings: opp: Introduce opp-peak-kBps and opp-avg-kBps bindings

Rob Herring
2020-05-11T21:51:27Z

On Fri, 24 Apr 2020 18:53:58 +0300, Georgi Djakov wrote:
> From: Saravana Kannan <saravanak@google.com>
>
> Interconnects often quantify their performance points in terms of
> bandwidth. So, add opp-peak-kBps (required) and opp-avg-kBps (optional) to
> allow specifying Bandwidth OPP tables in DT.
>
> opp-peak-kBps is a required property that replaces opp-hz for Bandwidth OPP
> tables.
>
> opp-avg-kBps is an optional property that can be used in Bandwidth OPP
> tables.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> v7:
> * I have dropped Rob's Reviewed-by, because of the minor change below:
> * In order to store the bandwidth values for multiple paths, the
> opp-peak-kBps and opp-avg-kBps are now defined as arrays of integers,
> instead of just integers.
> * Improved wording (Viresh)
>
> v6: https://lore.kernel.org/r/20191207002424.201796-2-saravanak@google.com
>
> Documentation/devicetree/bindings/opp/opp.txt | 20 ++++++++++++++++---
> .../devicetree/bindings/property-units.txt | 4 ++++
> 2 files changed, 21 insertions(+), 3 deletions(-)
>

Reviewed-by: Rob Herring <robh@kernel.org>