From: Sean Christopherson <sean.j.christopherson@intel.com>
To: stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ben Hutchings <ben.hutchings@codethink.co.uk>,
Sasha Levin <sashal@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org,
Tobias Urdin <tobias.urdin@binero.com>
Subject: [PATCH 4.19 STABLE v2 0/2] KVM: VMX: Fix null pointer dereference
Date: Mon, 11 May 2020 17:28:13 -0700 [thread overview]
Message-ID: <20200512002815.2708-1-sean.j.christopherson@intel.com> (raw)
A simple fix for a null pointer dereference in vmx_vcpu_run() with an
ugly-but-safe prereq patch.
The even uglier ASM_CALL_CONSTRAINT is gone in v2 as I finally figured
out why vmx_return was undefined: GCC dropped the entire asm blob because
all outputs were deemed unused.
v2:
- Document why there is no exact upstream commit for the fix, with
--verbose. [Greg]
- Tag the asm blob as volatile and drop the ASM_CALL_CONSTRAINT hack.
Sean Christopherson (2):
KVM: VMX: Explicitly reference RCX as the vmx_vcpu pointer in asm
blobs
KVM: VMX: Mark RCX, RDX and RSI as clobbered in vmx_vcpu_run()'s asm
blob
arch/x86/kvm/vmx.c | 91 +++++++++++++++++++++++++---------------------
1 file changed, 50 insertions(+), 41 deletions(-)
--
2.26.0
next reply other threads:[~2020-05-12 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 0:28 Sean Christopherson [this message]
2020-05-12 0:28 ` [PATCH 4.19 STABLE v2 1/2] KVM: VMX: Explicitly reference RCX as the vmx_vcpu pointer in asm blobs Sean Christopherson
2020-05-12 0:28 ` [PATCH 4.19 STABLE v2 2/2] KVM: VMX: Mark RCX, RDX and RSI as clobbered in vmx_vcpu_run()'s asm blob Sean Christopherson
2020-05-12 11:43 ` [PATCH 4.19 STABLE v2 0/2] KVM: VMX: Fix null pointer dereference Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512002815.2708-1-sean.j.christopherson@intel.com \
--to=sean.j.christopherson@intel.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tobias.urdin@binero.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox