From: Andrew Lunn <andrew@lunn.ch>
To: Doug Berger <opendmb@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/4] net: ethernet: introduce phy_set_pause
Date: Tue, 12 May 2020 02:51:18 +0200 [thread overview]
Message-ID: <20200512005118.GE409897@lunn.ch> (raw)
In-Reply-To: <1589243050-18217-4-git-send-email-opendmb@gmail.com>
On Mon, May 11, 2020 at 05:24:09PM -0700, Doug Berger wrote:
> This commit introduces the phy_set_pause function to the phylib as
> a helper to support the set_pauseparam ethtool method.
>
> It is hoped that the new behavior introduced by this function will
> be widely embraced and the phy_set_sym_pause and phy_set_asym_pause
> functions can be deprecated. Those functions are retained for all
> existing users and for any desenting opinions on my interpretation
> of the functionality.
It would be good to add comments to phy_set_sym_pause and
phy_set_asym_pause indicating they are deprecated and point to
phy_set_pause().
Andrew
next prev parent reply other threads:[~2020-05-12 0:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 0:24 [PATCH net-next 0/4] Extend phylib implementation of pause support Doug Berger
2020-05-12 0:24 ` [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting Doug Berger
2020-05-12 0:47 ` Andrew Lunn
2020-05-12 18:31 ` Doug Berger
2020-05-12 18:37 ` Andrew Lunn
2020-05-12 18:55 ` Russell King - ARM Linux admin
2020-05-13 3:48 ` Doug Berger
2020-05-13 5:34 ` Russell King - ARM Linux admin
2020-05-13 9:20 ` Russell King - ARM Linux admin
2020-05-13 13:49 ` Andrew Lunn
2020-05-13 14:59 ` Michal Kubecek
2020-05-13 17:14 ` Russell King - ARM Linux admin
2020-05-13 22:09 ` Doug Berger
2020-05-13 21:31 ` Doug Berger
2020-05-13 21:27 ` Doug Berger
2020-05-12 19:08 ` Michal Kubecek
2020-05-13 2:37 ` Doug Berger
2020-05-12 3:16 ` Florian Fainelli
2020-05-12 0:24 ` [PATCH net-next 2/4] net: add autoneg parameter to linkmode_set_pause Doug Berger
2020-05-12 0:24 ` [PATCH net-next 3/4] net: ethernet: introduce phy_set_pause Doug Berger
2020-05-12 0:51 ` Andrew Lunn [this message]
2020-05-12 18:46 ` Doug Berger
2020-05-12 3:22 ` Florian Fainelli
2020-05-13 9:42 ` Russell King - ARM Linux admin
2020-05-13 21:39 ` Doug Berger
2020-05-12 0:24 ` [PATCH net-next 4/4] net: bcmgenet: add support for ethtool flow control Doug Berger
2020-05-12 3:24 ` Florian Fainelli
2020-05-13 9:52 ` Russell King - ARM Linux admin
2020-05-13 22:00 ` Doug Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512005118.GE409897@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox