From: Christoph Hellwig <hch@lst.de>
To: Dimitri Sivanich <sivanich@hpe.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Christoph Hellwig <hch@lst.de>,
"H. Peter Anvin" <hpa@zytor.com>, Russ Anderson <rja@hpe.com>,
Mike Travis <mike.travis@hpe.com>,
Steve Wahl <steve.wahl@hpe.com>
Subject: Re: [PATCH] x86/platform/uv: HUB RTC cleanup
Date: Tue, 12 May 2020 06:21:49 +0200 [thread overview]
Message-ID: <20200512042149.GA31507@lst.de> (raw)
In-Reply-To: <20200511223535.GA23676@hpe.com>
On Mon, May 11, 2020 at 05:35:35PM -0500, Dimitri Sivanich wrote:
> Remove unused event code and other cleanup for HUB RTC.
Can you explain how this is dead? That's not entirely obvious
from the patch. Also you probably want to split it the cleans
into one or several additional patches and aso document them in
the commit log(s).
> diff --git a/arch/x86/platform/uv/uv_time.c b/arch/x86/platform/uv/uv_time.c
> index 7af31b245636..1777b7164ff8 100644
> --- a/arch/x86/platform/uv/uv_time.c
> +++ b/arch/x86/platform/uv/uv_time.c
> @@ -1,25 +1,18 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * SGI RTC clock/timer routines.
> + * HPE RTC clock routine.
Might be worth mentioning this is for the UV platform? Both the
old SGI and thew new HPE are not very descriptive.
prev parent reply other threads:[~2020-05-12 4:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 22:35 [PATCH] x86/platform/uv: HUB RTC cleanup Dimitri Sivanich
2020-05-12 4:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512042149.GA31507@lst.de \
--to=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=mingo@redhat.com \
--cc=rja@hpe.com \
--cc=sivanich@hpe.com \
--cc=steve.wahl@hpe.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox