Re: [PATCH v3 2/6] pstore/platform: Pass max_reason to kmesg dump

Joe Perches
2020-05-06T21:25:47Z

On Wed, 2020-05-06 at 14:15 -0700, Kees Cook wrote:
> From: Pavel Tatashin <pasha.tatashin@soleen.com>
>
> Add a new member to struct pstore_info for passing information about
> kmesg dump maximum reason. This allows a finer control of what kmesg
> dumps are sent to pstore storage backends.

trivia:

> diff --git a/include/linux/pstore.h b/include/linux/pstore.h
[]
> @@ -96,6 +96,12 @@ struct pstore_record {
> *
> * @read_mutex: serializes @open, @read, @close, and @erase callbacks
> * @flags: bitfield of frontends the backend can accept writes for
> + * @max_reason: Used when PSTORE_FLAGS_DMESG is set. Contains the
> + * kmsg_dump_reason enum value. KMSG_DUMP_UNDEF means
> + * "use existing kmsg_dump() filtering, based on the
> + * printk.always_kmsg_dump boot param" (which is either
> + * KMSG_DUMP_OOPS when false, or KMSG_DUMP_MAX when
> + * tree); see printk.always_kmsg_dump for more details.

s/tree/true/