From: Peter Zijlstra <peterz@infradead.org>
To: Steven Price <steven.price@arm.com>
Cc: Jan Beulich <jbeulich@suse.com>,
the arch/x86 maintainers <x86@kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: your "x86: mm: convert dump_pagetables to use walk_page_range" change
Date: Tue, 12 May 2020 15:18:57 +0200 [thread overview]
Message-ID: <20200512131857.GI2978@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <d95d756d-e940-d81e-d6ca-e45054df72c4@arm.com>
On Tue, May 12, 2020 at 02:02:51PM +0100, Steven Price wrote:
> > Additionally I'd like to note that note_page()'s "unsigned long val"
> > parameter isn't wide enough for 32-bit PAE PTEs, and hence the NX
> > flag will always be seen as clear in new_prot in such configs.
>
> Ah, interesting. I'm not sure what type is actually guaranteed to be
> correct. pgprotval_t is x86 specific, but it might be necessary to extend it
> to other architectures. I think I got the "unsigned long" from the generic
> page.h (and because it happens to work on most architectures) - but hadn't
> noticed that that file was specifically only for NOMMU architectures.
unsigned long long should cover the i386-PAE / ARMv7-LPAE cases. I
can't, from teh top of my head, remember if there's anybody else who has
a longer PTE.
prev parent reply other threads:[~2020-05-12 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 9:39 your "x86: mm: convert dump_pagetables to use walk_page_range" change Jan Beulich
2020-05-12 13:02 ` Steven Price
2020-05-12 13:09 ` Jan Beulich
2020-05-12 13:18 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512131857.GI2978@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox