Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs

Vinod Koul
2020-05-14T13:45:27Z

On 30-04-20, 11:00, Bjorn Andersson wrote:
> Add the SM8250 audio, compute and sensor remoteprocs to the PAS DT
> binding.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

>
> Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v1:
> - Changed adsp power-domains to lcx and added missing lmx
>
> .../devicetree/bindings/remoteproc/qcom,adsp.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index 9938918b2fea..c18c1b8d2869 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -21,6 +21,9 @@ on the Qualcomm ADSP Hexagon core.
> "qcom,sm8150-cdsp-pas"
> "qcom,sm8150-mpss-pas"
> "qcom,sm8150-slpi-pas"
> + "qcom,sm8250-adsp-pas"
> + "qcom,sm8250-cdsp-pas"
> + "qcom,sm8250-slpi-pas"
>
> - interrupts-extended:
> Usage: required
> @@ -44,6 +47,9 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sm8150-adsp-pas:
> qcom,sm8150-cdsp-pas:
> qcom,sm8150-slpi-pas:
> + qcom,sm8250-adsp-pas:
> + qcom,sm8250-cdsp-pas:
> + qcom,sm8250-slpi-pas:
> must be "wdog", "fatal", "ready", "handover", "stop-ack"
> qcom,qcs404-wcss-pas:
> qcom,sm8150-mpss-pas:
> @@ -105,10 +111,13 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sdm845-cdsp-pas:
> qcom,sm8150-adsp-pas:
> qcom,sm8150-cdsp-pas:
> + qcom,sm8250-cdsp-pas:
> must be "cx", "load_state"
> qcom,sm8150-mpss-pas:
> must be "cx", "load_state", "mss"
> + qcom,sm8250-adsp-pas:
> qcom,sm8150-slpi-pas:
> + qcom,sm8250-slpi-pas:
> must be "lcx", "lmx", "load_state"
>
> - memory-region:
> --
> 2.24.0

--
~Vinod