From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471E3C2D0F6 for ; Tue, 12 May 2020 16:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EE9F206B7 for ; Tue, 12 May 2020 16:14:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727847AbgELQON (ORCPT ); Tue, 12 May 2020 12:14:13 -0400 Received: from verein.lst.de ([213.95.11.211]:42018 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgELQON (ORCPT ); Tue, 12 May 2020 12:14:13 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9157D68C65; Tue, 12 May 2020 18:14:11 +0200 (CEST) Date: Tue, 12 May 2020 18:14:11 +0200 From: Christoph Hellwig To: Chen Zhou Cc: hch@lst.de, sagi@grimberg.me, chaitanya.kulkarni@wdc.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] nvmet: replace kstrndup() with kmemdup_nul() Message-ID: <20200512161411.GC6049@lst.de> References: <20200508115906.165223-1-chenzhou10@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508115906.165223-1-chenzhou10@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 07:59:06PM +0800, Chen Zhou wrote: > It is more efficient to use kmemdup_nul() if the size is known exactly. > > The doc in kernel: > "Note: Use kmemdup_nul() instead if the size is known exactly." > > Signed-off-by: Chen Zhou Thanks, applied to nvme-5.8.