Re: [PATCH 3/4] dt-bindings: i2c-stm32: add SMBus Alert bindings

Rob Herring
2020-05-13T02:19:42Z

On Tue, May 05, 2020 at 07:51:10AM +0200, Alain Volmat wrote:
> Add a new binding of the i2c-stm32f7 driver to enable the handling
> of the SMBUS-Alert
>
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
> ---
> Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> index b50a2f420b36..04c0882c3661 100644
> --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> @@ -36,6 +36,10 @@ allOf:
> minItems: 3
> maxItems: 3
>
> + st,smbus-alert:
> + description: Enable the SMBus Alert feature
> + $ref: /schemas/types.yaml#/definitions/flag
> +

We already have smbus_alert interrupt. Can't you just check for this in
the slave nodes and enable if found?

> - if:
> properties:
> compatible:
> --
> 2.17.1
>