Re: [PATCH] char: ipmi: convert to use i2c_new_client_device()

Corey Minyard
2020-05-13T11:18:33Z

On Wed, May 13, 2020 at 10:37:46AM +0200, Wolfram Sang wrote:
> On Tue, May 12, 2020 at 04:45:32PM -0500, minyard@acm.org wrote:
> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > Move away from the deprecated API.
> >
> > Based on a patch by Wolfram Sang <wsa+renesas@sang-engineering.com>.
> >
> > Signed-off-by: Corey Minyard <cminyard@mvista.com>
> > ---
> > I think this works.
>
> Yes, we can do it like this (despite the question from earlier if it is
> really needed). I fixed other drivers using this pattern, too.

I was wondering whether this is really needed, too, but I'm not 100%
sure it can be removed in all cases. This is the safer route.

>
> As Stephen Rothwell pointed out, you either need to remove my "From:" or
> add my SoB. I am fine with both.

It was enough of a rewrite that you as the author didn't seem right.
I've fixed the From line, sorry about that.

-corey

>
> Thanks,
>
> Wolfram
>