* [PATCH -next] iommu/amd: Remove set but not used variable 'iommu'
@ 2020-05-08 13:40 YueHaibing
2020-05-13 8:57 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-05-08 13:40 UTC (permalink / raw)
To: Joerg Roedel; +Cc: YueHaibing, iommu, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/iommu/amd_iommu.c: In function 'amd_iommu_uninit_device':
drivers/iommu/amd_iommu.c:422:20: warning:
variable 'iommu' set but not used [-Wunused-but-set-variable]
commit dce8d6964ebd ("iommu/amd: Convert to probe/release_device() call-backs")
involved this, remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/iommu/amd_iommu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index fef3689ee535..2b8eb58d2bea 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -419,15 +419,12 @@ static void iommu_ignore_device(struct device *dev)
static void amd_iommu_uninit_device(struct device *dev)
{
struct iommu_dev_data *dev_data;
- struct amd_iommu *iommu;
int devid;
devid = get_device_id(dev);
if (devid < 0)
return;
- iommu = amd_iommu_rlookup_table[devid];
-
dev_data = search_dev_data(devid);
if (!dev_data)
return;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] iommu/amd: Remove set but not used variable 'iommu'
2020-05-08 13:40 [PATCH -next] iommu/amd: Remove set but not used variable 'iommu' YueHaibing
@ 2020-05-13 8:57 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2020-05-13 8:57 UTC (permalink / raw)
To: YueHaibing; +Cc: iommu, linux-kernel, kernel-janitors
On Fri, May 08, 2020 at 01:40:36PM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/iommu/amd_iommu.c: In function 'amd_iommu_uninit_device':
> drivers/iommu/amd_iommu.c:422:20: warning:
> variable 'iommu' set but not used [-Wunused-but-set-variable]
>
> commit dce8d6964ebd ("iommu/amd: Convert to probe/release_device() call-backs")
> involved this, remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/iommu/amd_iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
Thanks for the patch, but I already applied
https://lore.kernel.org/r/20200509015645.3236-1-cai@lca.pw
Regards,
Joerg
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-13 8:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-08 13:40 [PATCH -next] iommu/amd: Remove set but not used variable 'iommu' YueHaibing
2020-05-13 8:57 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox