From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8671CA90AF for ; Wed, 13 May 2020 09:03:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7636206CC for ; Wed, 13 May 2020 09:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732330AbgEMJDX (ORCPT ); Wed, 13 May 2020 05:03:23 -0400 Received: from 8bytes.org ([81.169.241.247]:42288 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730634AbgEMJDX (ORCPT ); Wed, 13 May 2020 05:03:23 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 63BBB46A; Wed, 13 May 2020 11:03:22 +0200 (CEST) Date: Wed, 13 May 2020 11:03:21 +0200 From: Joerg Roedel To: Marek Szyprowski Cc: dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Robin Murphy , Bartlomiej Zolnierkiewicz , linux-arm-kernel@lists.infradead.org, David Airlie , Daniel Vetter Subject: Re: [PATCH v4 03/38] iommu: add generic helper for mapping sgtable objects Message-ID: <20200513090320.GH9820@8bytes.org> References: <20200512085710.14688-1-m.szyprowski@samsung.com> <20200512090058.14910-1-m.szyprowski@samsung.com> <20200512090058.14910-3-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200512090058.14910-3-m.szyprowski@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, On Tue, May 12, 2020 at 11:00:23AM +0200, Marek Szyprowski wrote: > --- > include/linux/iommu.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Some nits below, with those fixed: Acked-by: Joerg Roedel > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 7cfd2dd..ba662ba 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -478,6 +478,22 @@ extern size_t iommu_map_sg_atomic(struct iommu_domain *domain, > extern void iommu_set_fault_handler(struct iommu_domain *domain, > iommu_fault_handler_t handler, void *token); > > +/** > + * iommu_map_sgtable - Map the given buffer to the IOMMU domain > + * @domain: The IOMMU domain to perfor ^^^^^^ Truncated comment? > + * @iova: The start addrees to map the buffer ^^^^^^^ Typo > + * @sgt: The sg_table object describing the buffer > + * @prot: IOMMU protection bits > + * > + * Create a mapping at @iova for the buffer described by a scatterlist > + * stored in the given sg_table object in the provided IOMMU domain. > + */ > +static inline size_t iommu_map_sgtable(struct iommu_domain *domain, > + unsigned long iova, struct sg_table *sgt, int prot) > +{ > + return iommu_map_sg(domain, iova, sgt->sgl, sgt->orig_nents, prot); > +} > + > extern void iommu_get_resv_regions(struct device *dev, struct list_head *list); > extern void iommu_put_resv_regions(struct device *dev, struct list_head *list); > extern void generic_iommu_put_resv_regions(struct device *dev, > -- > 1.9.1