From: Corey Minyard <cminyard@mvista.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: minyard@acm.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: ipmi: convert to use i2c_new_client_device()
Date: Wed, 13 May 2020 06:18:25 -0500 [thread overview]
Message-ID: <20200513111825.GB9928@minyard.net> (raw)
In-Reply-To: <20200513083745.GC1043@ninjato>
On Wed, May 13, 2020 at 10:37:46AM +0200, Wolfram Sang wrote:
> On Tue, May 12, 2020 at 04:45:32PM -0500, minyard@acm.org wrote:
> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > Move away from the deprecated API.
> >
> > Based on a patch by Wolfram Sang <wsa+renesas@sang-engineering.com>.
> >
> > Signed-off-by: Corey Minyard <cminyard@mvista.com>
> > ---
> > I think this works.
>
> Yes, we can do it like this (despite the question from earlier if it is
> really needed). I fixed other drivers using this pattern, too.
I was wondering whether this is really needed, too, but I'm not 100%
sure it can be removed in all cases. This is the safer route.
>
> As Stephen Rothwell pointed out, you either need to remove my "From:" or
> add my SoB. I am fine with both.
It was enough of a rewrite that you as the author didn't seem right.
I've fixed the From line, sorry about that.
-corey
>
> Thanks,
>
> Wolfram
>
prev parent reply other threads:[~2020-05-13 11:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 21:09 [PATCH 0/1] char: convert to use new I2C API Wolfram Sang
2020-03-26 21:09 ` [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device() Wolfram Sang
2020-05-12 16:30 ` Wolfram Sang
2020-05-12 18:25 ` Corey Minyard
2020-05-12 20:07 ` Wolfram Sang
2020-05-12 21:14 ` Corey Minyard
2020-05-13 7:10 ` Wolfram Sang
2020-05-13 12:28 ` Corey Minyard
2020-05-12 21:45 ` [PATCH] " minyard
2020-05-13 8:37 ` Wolfram Sang
2020-05-13 11:18 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513111825.GB9928@minyard.net \
--to=cminyard@mvista.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox