From: Corey Minyard <minyard@acm.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device()
Date: Wed, 13 May 2020 07:28:50 -0500 [thread overview]
Message-ID: <20200513122850.GT9902@minyard.net> (raw)
In-Reply-To: <20200513071004.GA1043@ninjato>
On Wed, May 13, 2020 at 09:10:04AM +0200, Wolfram Sang wrote:
>
> > > - addr_info->added_client = i2c_new_device(to_i2c_adapter(adev),
> > > - &addr_info->binfo);
> > > + addr_info->added_client = i2c_new_client_device(to_i2c_adapter(adev),
> > > + &addr_info->binfo);
> >
> > i2c_new_client_device returns an ERR_PTR, not NULL on error. So this
>
> Yes, this is the main motivation for the new API.
>
> > needs some more work. I'll send something out soon.
>
> Why does it need that work? 'added_client' is only used with
> i2c_unregister_device() which has been fixed to handle ERR_PTR as well.
> Or am I missing something?
>
No, I didn't look to see if i2c_unregister_device could handle that.
-corey
next prev parent reply other threads:[~2020-05-13 12:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 21:09 [PATCH 0/1] char: convert to use new I2C API Wolfram Sang
2020-03-26 21:09 ` [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device() Wolfram Sang
2020-05-12 16:30 ` Wolfram Sang
2020-05-12 18:25 ` Corey Minyard
2020-05-12 20:07 ` Wolfram Sang
2020-05-12 21:14 ` Corey Minyard
2020-05-13 7:10 ` Wolfram Sang
2020-05-13 12:28 ` Corey Minyard [this message]
2020-05-12 21:45 ` [PATCH] " minyard
2020-05-13 8:37 ` Wolfram Sang
2020-05-13 11:18 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513122850.GT9902@minyard.net \
--to=minyard@acm.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox