Re: [PATCH v13 8/9] nvmet-passthru: Add enable/disable helpers

Chaitanya Kulkarni
2020-06-11T23:13:47Z

On 5/14/20 10:23 AM, Logan Gunthorpe wrote:
> + if (subsys->ver < NVME_VS(1, 2, 1)) {
> + pr_warn("nvme controller version is too old: %d.%d.%d, advertising 1.2.1\n",
Is it more than 80 char ? can it be ?
pr_warn("nvme controller version is too old: ");
pr_warn("%d.%d.%d, advertising 1.2.1\n",
> + (int)NVME_MAJOR(subsys->ver),
> + (int)NVME_MINOR(subsys->ver),
> + (int)NVME_TERTIARY(subsys->ver));
> + subsys->ver = NVME_VS(1, 2, 1);
> + }

NVMe blktests are running on QEMU based controller. This will generate
warning every-time.

Also, I didn't understand int type cast, I wonder under what condition
all these macros will return -ve values since ver of type u64 ?