Re: [PATCH v13 5/9] nvme-core: Introduce nvme_ctrl_get_by_path()

Logan Gunthorpe
2020-06-11T23:09:45Z

On 2020-06-11 5:02 p.m., Chaitanya Kulkarni wrote:
> On 5/14/20 10:23 AM, Logan Gunthorpe wrote:
>> +#ifdef CONFIG_NVME_TARGET_PASSTHRU
>> +/*
>> + * The exports that follow within this ifdef are only for
>> + * use by the nvmet-passthru and should not be used for
>> + * other things.
>> + */
>
> The above comment is duplicate #ifdef is self explanatory and I didn't
> find similar style in existing repo (e.g. CONFIG_NVME_MULTIPATH,
> CONFIG_BLK_SED_OPAL) so let's not introduce new style which will create
> confusion to future code.

Christoph specifically asked for this ifdef and comment.

Logan