From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96317C433DF for ; Thu, 14 May 2020 19:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ADB720675 for ; Thu, 14 May 2020 19:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589482908; bh=dMS1BI4dhRHxWZzRrBMqPXB+b0yJ1yoqLZ7lWTjrRu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iiozGM7V6ggpyNlLCJ4Qaq4cfOX1onGHvsDnuIwPLkfjdB1D/ca7kpp8lU9GQsIKd 8TcCJITK0DKUjKHcBUY4m+uJMJiUTxdwWdEAUFHVDPw0/dASs5ooBiSgS4UV9J5Z01 E1SZKTQ1X0fM5aCCVVHTvbCWu8SVEexHH+ZMxFvc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729703AbgENTBr (ORCPT ); Thu, 14 May 2020 15:01:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:56028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729375AbgENSzZ (ORCPT ); Thu, 14 May 2020 14:55:25 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 957EA20727; Thu, 14 May 2020 18:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589482525; bh=dMS1BI4dhRHxWZzRrBMqPXB+b0yJ1yoqLZ7lWTjrRu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tiLoQHIGtrR2TSQKLfTQlF2bB7VY19EHYezLRtxh1lik+OF4HlxpcoqOS82U5ZN0X FiBojpGGAjH/E2IMbU9pE4Wzp145Hx5lcmVtruzTXGAlWdgUcMYTKqOTS2Wj+rn4KY LWwFghuf+0Ji7LuFETcEHlm55P1GgzjKnLinBZAI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: James Hilliard , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.14 20/39] component: Silence bind error on -EPROBE_DEFER Date: Thu, 14 May 2020 14:54:37 -0400 Message-Id: <20200514185456.21060-20-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200514185456.21060-1-sashal@kernel.org> References: <20200514185456.21060-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: James Hilliard [ Upstream commit 7706b0a76a9697021e2bf395f3f065c18f51043d ] If a component fails to bind due to -EPROBE_DEFER we should not log an error as this is not a real failure. Fixes messages like: vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517 vc4-drm soc:gpu: master bind failed: -517 Signed-off-by: James Hilliard Link: https://lore.kernel.org/r/20200411190241.89404-1-james.hilliard1@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/base/component.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index 08da6160e94dd..55f0856bd9b5e 100644 --- a/drivers/base/component.c +++ b/drivers/base/component.c @@ -162,7 +162,8 @@ static int try_to_bring_up_master(struct master *master, ret = master->ops->bind(master->dev); if (ret < 0) { devres_release_group(master->dev, NULL); - dev_info(master->dev, "master bind failed: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_info(master->dev, "master bind failed: %d\n", ret); return ret; } @@ -431,8 +432,9 @@ static int component_bind(struct component *component, struct master *master, devres_release_group(component->dev, NULL); devres_release_group(master->dev, NULL); - dev_err(master->dev, "failed to bind %s (ops %ps): %d\n", - dev_name(component->dev), component->ops, ret); + if (ret != -EPROBE_DEFER) + dev_err(master->dev, "failed to bind %s (ops %ps): %d\n", + dev_name(component->dev), component->ops, ret); } return ret; -- 2.20.1