From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D69EAC433DF for ; Thu, 14 May 2020 18:55:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA935207F7 for ; Thu, 14 May 2020 18:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589482554; bh=4zIpcCXF6mOwa7JcGshnJHN7vHRqZxuFzWlbLOYLqz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=n+vxRKNDJ2gh7tM+8ksXyVu9aPrgUUC/hwkrR3rteXHRX3HMxQ1g6IKeCMJcyFvFj MeL2sPVE+p6GAoInjXKdxP9AK//KnLVwLAqv3rNMVU+tFubRsAhZik5aQxagkb4+vf 9mcar2f+3Yzyhv+2S3mNS6+ugR1d+dKQrr6QtBxo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729520AbgENSzx (ORCPT ); Thu, 14 May 2020 14:55:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:56284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729446AbgENSzl (ORCPT ); Thu, 14 May 2020 14:55:41 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F4652076A; Thu, 14 May 2020 18:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589482540; bh=4zIpcCXF6mOwa7JcGshnJHN7vHRqZxuFzWlbLOYLqz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IarTvLVRGW5MLbDz12khV9m+Xqeqf3VWTj3ehO4bCbhz+T2/NrWrBf3P9edXusoNh 1EeCwEnbOkUUqOA6Jg38EjJ3VPvLYo2Lt/KYS4kLaucL/Rq8/K3TUVp81iOUn4f74f bF/Z+t2eyMIjjB4fTfKCjNy/R7spoxPatgzjcajs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wu Bo , "Yan, Zheng" , Ilya Dryomov , Sasha Levin , ceph-devel@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 33/39] ceph: fix double unlock in handle_cap_export() Date: Thu, 14 May 2020 14:54:50 -0400 Message-Id: <20200514185456.21060-33-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200514185456.21060-1-sashal@kernel.org> References: <20200514185456.21060-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wu Bo [ Upstream commit 4d8e28ff3106b093d98bfd2eceb9b430c70a8758 ] If the ceph_mdsc_open_export_target_session() return fails, it will do a "goto retry", but the session mutex has already been unlocked. Re-lock the mutex in that case to ensure that we don't unlock it twice. Signed-off-by: Wu Bo Reviewed-by: "Yan, Zheng" Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/caps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c index 1b5a50848b5be..589cfe3ed873b 100644 --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -3502,6 +3502,7 @@ static void handle_cap_export(struct inode *inode, struct ceph_mds_caps *ex, WARN_ON(1); tsession = NULL; target = -1; + mutex_lock(&session->s_mutex); } goto retry; -- 2.20.1